Merge remote-tracking branch 'upstream/main' into review_feedback

Author: dibarbet

CHANGELOG.md

@@ -4,6 +4,27 @@
 - Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)
 
 # 2.86.x
+* Bump Roslyn to 5.0.0-1.25358.1 (PR: [#8402](https://github.com/dotnet/vscode-csharp/pull/8402))
+  * Initial support for adding obsolete attributes to primary constructors(PR: [#79271](https://github.com/dotnet/roslyn/pull/79271))
+  * Allow the Razor extension to report telemetry (and initialize)(PR: [#79254](https://github.com/dotnet/roslyn/pull/79254))
+  * Use same location for 'use implicit object' as we do for 'use collection expression'.(PR: [#79265](https://github.com/dotnet/roslyn/pull/79265))
+  * Use the miscellaneous files project name for rich misc projects(PR: [#79267](https://github.com/dotnet/roslyn/pull/79267))
+  * Razor: Don't double register for document sync(PR: [#79241](https://github.com/dotnet/roslyn/pull/79241))
+  * Allow LanguageServerProjectSystems to load into more than one workspace(PR: [#78975](https://github.com/dotnet/roslyn/pull/78975))
+  * Improve diagnostic for ambiguous predefined type(PR: [#79196](https://github.com/dotnet/roslyn/pull/79196))
+  * Fix renaming constructor via alias(PR: [#79175](https://github.com/dotnet/roslyn/pull/79175))
+  * Speed up performance of remove-unused-imports fix all(PR: [#79173](https://github.com/dotnet/roslyn/pull/79173))
+  * Improve performance in metadata-to-project-reference conversion(PR: [#79163](https://github.com/dotnet/roslyn/pull/79163))
+  * Fix issue where we offered to use a collection expression when teh user didn't have a viable Add method(PR: [#79157](https://github.com/dotnet/roslyn/pull/79157))
+  * Don't load the razor redirector unless it could actually be a razor assembly(PR: [#79154](https://github.com/dotnet/roslyn/pull/79154))
+  * Tweak clarity rules for parentheses where ?? is involved(PR: [#79159](https://github.com/dotnet/roslyn/pull/79159))
+  * Avoid hitting object pool when not needed(PR: [#79158](https://github.com/dotnet/roslyn/pull/79158))
+  * Merge 'extension operators' into 'main'(PR: [#79151](https://github.com/dotnet/roslyn/pull/79151))
+  * Extensions: interceptors(PR: [#79010](https://github.com/dotnet/roslyn/pull/79010))
+  * Small but trivial allocation improvement in FileWatchedReferenceFactory.StopWatchingReference(PR: [#79140](https://github.com/dotnet/roslyn/pull/79140))
+  * Slight allocation reduction in CommandLineParser.FlattenArgs(PR: [#79139](https://github.com/dotnet/roslyn/pull/79139))
+* Fix promptForDevKitDebugConfigurations without CDK installed(PR: [#8390](https://github.com/dotnet/vscode-csharp/pull/8390))
+* Remove Razor ForceRuntimeCodeGeneration flag(PR: [#8398](https://github.com/dotnet/vscode-csharp/pull/8398))
 
 # 2.85.x
 * Bump Roslyn to 5.0.0-1.25326.2 (PR: [#8386](https://github.com/dotnet/vscode-csharp/pull/8386))

CONTRIBUTING.md

@@ -36,12 +36,15 @@ Follow these steps to build, run, and test the repository:
 
 #### Building
 
+If you have the ability to run powershell, you can invoke "init.ps1" from the root of the repo. If not, the following steps will get build going for you as well:
+
 1. Run `npm install -g vsts-npm-auth`, then run `vsts-npm-auth -config .npmrc` - This command will configure your credentials for the next command.
    a.  If you have already authenticated before, but the token expired, you may need to run `vsts-npm-auth -config .npmrc -f` instead.
 2. Run `npm i` - This command installs the project dependencies.
 3. Run `npm i -g gulp` - This command installs Gulp globally.
 4. Run `gulp installDependencies` - This command downloads the various dependencies as specified by the version in the [package.json](package.json) file.
-5. Run `code .` - This command opens the project in Visual Studio Code.
+
+You can now run `code .` - This command opens the project in Visual Studio Code.
 
 #### Running
 
@@ -168,7 +171,7 @@ To package this extension, we need to create VSIX Packages. The VSIX packages ca
 
 ## Updating the `Roslyn` Language Server Version
 
-In order to pull in new packages from upstreams into the msft_consumption feed we use for restoring, you will need to be a member of the 'CSharp VS Code Extension contributors' group in the [Azure Devops instance](https://dev.azure.com/azure-public/vside/_settings/teams).  
+In order to pull in new packages from upstreams into the msft_consumption feed we use for restoring, you will need to be a member of the 'CSharp VS Code Extension contributors' group in the [Azure Devops instance](https://dev.azure.com/azure-public/vside/_settings/teams).
 
 To update the version of the roslyn server used by the extension do the following:
 1.  Find the the Roslyn signed build you want from [here](https://dnceng.visualstudio.com/internal/_build?definitionId=327&_a=summary).  Typically the latest successful build of main is fine.
@@ -195,5 +198,5 @@ The marketplace release is managed by an internal AzDo pipeline.  On the pipelin
 1.  The branch will **always** be main, no matter if release a build from prerelease or release.
 2.  Uncheck the "test" option.
 3.  In "Resources", choose "dotnet-vscode-csharp [officialBuildCI]", then check only the build that should be released, and then confirm with "Use selected run".  Based on the selected build, it will automatically determine if it is prerelease or release. ![release pipeline image](./docs/release_pipeline.png)
-4.  The pipeline parameters should then look something like the following image.  Hit "Run". ![release pipeline parameters image](./docs/release_pipeline_params.png) 
+4.  The pipeline parameters should then look something like the following image.  Hit "Run". ![release pipeline parameters image](./docs/release_pipeline_params.png)
 5.  After a bit, the pipeline will request approval from an authorized approver before it actually uploads to the marketplace.  Hit approve and it will continue.

SUPPORT.md

@@ -68,7 +68,7 @@ For issues with Razor, the Razor Log output window can contain useful informatio
 4. **Reset the Log Level**:
    - Once the logs are collected, reset the log level to `Info`.
 
-#### Project Loading Problems
+### Project Loading Problems
 
 Missing language features are often caused by a failure to load the project(s) or solution. To diagnose and resolve these issues, follow these steps:
 
@@ -86,7 +86,7 @@ Missing language features are often caused by a failure to load the project(s) o
    - If you are using C# Dev Kit, check the Solution Explorer to ensure the project is displayed with the expected references.
    - If the references or structure are not as expected, include the contents of the `Projects` output window in your issue report.
 
-#### Colorization problems
+### Colorization problems
 If you encounter issues with document classification (e.g., incorrect syntax highlighting or colorization), please provide the following information to help us diagnose the problem:
 
 1. **Theme in Use**:
@@ -101,7 +101,7 @@ If you encounter issues with document classification (e.g., incorrect syntax hig
 
      ![Inspect Tokens and Scopes Output](./docs/inspect_tokens.png)
 
-#### Diagnostics problems
+### Diagnostics problems
 
 For issues with diagnostics, please provide values of the background analysis scope options, `dotnet.backgroundAnalysis.analyzerDiagnosticsScope` and `dotnet.backgroundAnalysis.compilerDiagnosticsScope`
 ![background analysis settings](./docs/background_analysis.png)
@@ -116,6 +116,21 @@ If the language server crashes, general logs are often helpful for diagnosing th
 > [!WARNING]
 > The dump can contain detailed information on the project - generally we will provide an email so that it can be shared privately
 
+#### Recording a language server trace
+
+When investigating performance issues, we may request a performance trace of the language server to diagnose what is causing the problem.  These are typically taken via [dotnet-trace](https://learn.microsoft.com/en-us/dotnet/core/diagnostics/dotnet-trace) (a cross platform tool to collect performance traces of .NET processes)
+
+The C# extension has a built in command, `csharp.recordTrace` to help with trace collection.  This command will install `dotnet-trace` as a global tool and invoke it against the language server.
+
+1.  Invoke the `csharp.recordTrace` command
+![alt text](docs/recordTraceCommand.png)
+2.  Select the folder to save the trace.
+3.  Accept the default trace arguments, or change them if requested
+![alt text](docs/recordTraceArgs.png)
+4.  A new terminal window will open to run the trace collection.  While the trace is running, reproduce the peformance issue.  When done, hit <Enter> or <Ctrl+C> in the trace window to stop the trace
+![alt text](docs/recordTraceTerminal.png)
+5.  Share the trace.  Note that the trace may contain PII, so generally we will provide an email or other confidential way to share the trace with us.
+
 ## Microsoft Support Policy
 
 Support for this project is limited to the resources listed above.

azure-pipelines.yml

@@ -17,6 +17,7 @@ pr:
   paths:
     exclude:
     - '*.md'
+    - 'version.json'
     - .github/*
     - azure-pipelines/release.yml
     - CHANGELOG.

docs/recordTraceArgs.png

@@ -0,0 +1,61 @@
+#!/usr/bin/env pwsh
+
+Write-Host "`nStarting init..." -ForegroundColor Cyan
+
+# Cross-platform command execution with error checking
+function Run-Command($command, $arguments, $errorMsg) {
+    Write-Host "Running: $command $($arguments -join ' ')" -ForegroundColor Yellow
+
+    # Check if command exists first
+    if (-not (Get-Command $command -ErrorAction SilentlyContinue)) {
+        throw "$command is not available on this system. Please ensure you have the command installed globally and it's available in your PATH."
+    }
+
+    & $command @arguments
+
+    if ($LASTEXITCODE -ne 0) {
+        throw "$errorMsg (Exit code: $LASTEXITCODE)"
+    }
+}
+
+
+Push-Location $PSScriptRoot
+
+try {
+    Write-Host "`n[1/5] Installing vsts-npm-auth globally..." -ForegroundColor Cyan
+    Run-Command "npm" @("install", "-g", "vsts-npm-auth") "Failed to install vsts-npm-auth."
+
+    Write-Host "`n[2/5] Authenticating with Azure DevOps..." -ForegroundColor Cyan
+    if (Test-Path ".npmrc") {
+        try {
+            Run-Command "vsts-npm-auth" @("-config", ".npmrc") "Initial authentication failed."
+        }
+        catch {
+            Write-Host "Initial authentication failed. Trying with force (-f) flag..." -ForegroundColor DarkYellow
+            Run-Command "vsts-npm-auth" @("-config", ".npmrc", "-f") "Forced authentication failed."
+        }
+    } else {
+        Write-Host ".npmrc file not found in the current directory." -ForegroundColor Red
+        throw ".npmrc file not found in the current directory."
+    }
+
+    Write-Host "`n[3/5] Installing project dependencies..." -ForegroundColor Cyan
+    Run-Command "npm" @("install") "Failed to install project dependencies."
+
+    Write-Host "`n[4/5] Installing Gulp globally..." -ForegroundColor Cyan
+    Run-Command "npm" @("install", "-g", "gulp") "Failed to install Gulp globally."
+
+    Write-Host "`n[5/5] Running gulp installDependencies..." -ForegroundColor Cyan
+    Run-Command "gulp" @("installDependencies") "Failed to run 'gulp installDependencies'."
+
+    Write-Host "`n✅ Setup complete." -ForegroundColor Green
+}
+catch {
+    Write-Host "`n❌ Setup failed: $($_.Exception.Message)" -ForegroundColor Red
+    exit 1
+}
+finally {
+    Pop-Location
+}
+
+

docs/recordTraceCommand.png

@@ -40,7 +40,7 @@
     "workspace"
   ],
   "defaults": {
-    "roslyn": "5.0.0-1.25326.2",
+    "roslyn": "5.0.0-1.25358.1",
     "omniSharp": "1.39.12",
     "razor": "10.0.0-preview.25329.6",
     "razorOmnisharp": "7.0.0-preview.23363.1",