Fix tests

Author: winstliu

src/features/reportIssue.ts

@@ -84,10 +84,8 @@ async function getMonoIfPlatformValid(isValidPlatformForMono: boolean, options:
     if (isValidPlatformForMono) {
         let monoVersion = "Unknown Mono version";
         try {
-            let monoInfo = await monoResolver.getHostExecutableInfo(options);
-            if (monoInfo) {
-                monoVersion = `OmniSharp using mono :${monoInfo.version}`;
-            }
+            const monoInfo = await monoResolver.getHostExecutableInfo(options);
+            monoVersion = `OmniSharp using mono: ${monoInfo.version}`;
         }
         catch (error) {
             monoVersion = `There is a problem with running OmniSharp on mono: ${error}`;

test/unitTests/features/reportIssue.test.ts

@@ -65,52 +65,52 @@ suite(`${reportIssue.name}`, () => {
     });
 
     test(`${OpenURL.name} event is created`, async () => {
-        await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeMonoResolver, fakeDotnetResolver);
+        await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeDotnetResolver, fakeMonoResolver);
         let events = eventBus.getEvents();
         expect(events).to.have.length(1);
         expect(events[0].constructor.name).to.be.equal(`${OpenURL.name}`);
     });
 
     test(`${OpenURL.name} event is created with the omnisharp-vscode github repo issues url`, async () => {
-        await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, false, options, fakeMonoResolver, fakeDotnetResolver);
+        await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, false, options, fakeDotnetResolver, fakeMonoResolver);
         let url = (<OpenURL>eventBus.getEvents()[0]).url;
         expect(url).to.include("https://github.com/OmniSharp/omnisharp-vscode/issues/new?body=Please paste the output from your clipboard");
     });
 
     suite("The body is passed to the vscode clipboard and", () => {
         test("it contains the vscode version", async () => {
-            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeMonoResolver, fakeDotnetResolver);
+            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeDotnetResolver, fakeMonoResolver);
             expect(issueBody).to.include(`**VSCode version**: ${vscodeVersion}`);
         });
 
         test("it contains the csharp extension version", async () => {
-            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeMonoResolver, fakeDotnetResolver);
+            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeDotnetResolver, fakeMonoResolver);
             expect(issueBody).to.include(`**C# Extension**: ${csharpExtVersion}`);
         });
 
         test("it contains dotnet info", async () => {
-            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeMonoResolver, fakeDotnetResolver);
+            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeDotnetResolver, fakeMonoResolver);
             expect(issueBody).to.contain(fakeDotnetInfo.FullInfo);
         });
 
         test("mono information is obtained when it is a valid mono platform", async () => {
-            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeMonoResolver, fakeDotnetResolver);
+            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeDotnetResolver, fakeMonoResolver);
             expect(fakeMonoResolver.getMonoCalled).to.be.equal(true);
         });
 
         test("mono version is put in the body when it is a valid mono platform", async () => {
-            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeMonoResolver, fakeDotnetResolver);
+            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeDotnetResolver, fakeMonoResolver);
             expect(fakeMonoResolver.getMonoCalled).to.be.equal(true);
             expect(issueBody).to.contain(fakeMonoInfo.version);
         });
 
         test("mono information is not obtained when it is not a valid mono platform", async () => {
-            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, false, options, fakeMonoResolver, fakeDotnetResolver);
+            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, false, options, fakeDotnetResolver, fakeMonoResolver);
             expect(fakeMonoResolver.getMonoCalled).to.be.equal(false);
         });
 
         test("The url contains the name, publisher and version for all the extensions that are not builtin", async () => {
-            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeMonoResolver, fakeDotnetResolver);
+            await reportIssue(vscode, csharpExtVersion, eventStream, getDotnetInfo, isValidForMono, options, fakeDotnetResolver, fakeMonoResolver);
             expect(issueBody).to.contain(extension2.packageJSON.name);
             expect(issueBody).to.contain(extension2.packageJSON.publisher);
             expect(issueBody).to.contain(extension2.packageJSON.version);