Merged PR 477536: Removed writeCommonPropsFile as it's not needed by Blue.

Fixed bug where the CSharp extension was overwriting the CSDevKit's common property file when it was trying to get the commonprops filepath.  As Blue does not send telemetry outside of the CSDevKit extension, it does not need to create a common props file for Telemetry to use.

Related work items: #1830937

Author: jonathanjyi

src/lsptoolshost/roslynLanguageServer.ts

@@ -437,6 +437,7 @@ export class RoslynLanguageServer {
             _channel.appendLine(`Starting server at ${serverPath}`);
         }
 
+        // shouldn't this arg only be set if it's running with CSDevKit?
         args.push("--telemetryLevel", this.telemetryReporter.telemetryLevel);
 
         let childProcess: cp.ChildProcessWithoutNullStreams;
@@ -528,9 +529,6 @@ export class RoslynLanguageServer {
 
         const extensionPaths = options.languageServerOptions.extensionsPaths || [this.getLanguageServicesDevKitComponentPath(exports)];
 
-        // required for the telemetry service to work
-        await exports.writeCommonPropsAsync(this.context);
-
         let args: string[] = [];
 
         for (const extensionPath of extensionPaths) {