Skip to content

Commit 4c5911a

Browse files
Add 'externalConsole' launch option (#390)
With this checkin, we now support an 'externalConsole' launch option. This option is specified by default for console projects. This completes the fix for: #175
1 parent b0d4ac7 commit 4c5911a

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

package.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,11 @@
269269
"description": "Environment variables passed to the program.",
270270
"default": { }
271271
},
272+
"externalConsole": {
273+
"type": "boolean",
274+
"description": "If 'true' the debugger should launch the target application into a new external console.",
275+
"default": true
276+
},
272277
"sourceFileMap": {
273278
"type": "object",
274279
"description": "Optional source file mappings passed to the debug engine. Example: '{ \"C:\\foo\":\"/home/user/foo\" }'",
@@ -428,7 +433,8 @@
428433
"program": "${workspaceRoot}/bin/Debug/<target-framework>/<project-name.dll>",
429434
"args": [],
430435
"cwd": "${workspaceRoot}",
431-
"stopAtEntry": false
436+
"stopAtEntry": false,
437+
"externalConsole": true
432438
},
433439
{
434440
"name": ".NET Core Launch (web)",

src/assets.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ interface ConsoleLaunchConfiguration extends DebugConfiguration {
2525
args: string[],
2626
cwd: string,
2727
stopAtEntry: boolean,
28-
env?: any
28+
env?: any,
29+
externalConsole?: boolean
2930
}
3031

3132
interface CommandLine {
@@ -138,6 +139,7 @@ function createLaunchConfiguration(targetFramework: string, executableName: stri
138139
program: '${workspaceRoot}/bin/Debug/' + targetFramework + '/'+ executableName,
139140
args: [],
140141
cwd: '${workspaceRoot}',
142+
externalConsole: true,
141143
stopAtEntry: false
142144
}
143145
}

src/coreclr-debug/main.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ function createProjectJson(targetRuntime: string): any
333333
},
334334
dependencies: {
335335
"Microsoft.VisualStudio.clrdbg": "14.0.25320-preview-3008693",
336-
"Microsoft.VisualStudio.clrdbg.MIEngine": "14.0.30527-preview-1",
336+
"Microsoft.VisualStudio.clrdbg.MIEngine": "14.0.30531-preview-1",
337337
"Microsoft.VisualStudio.OpenDebugAD7": "1.0.20527-preview-1",
338338
"NETStandard.Library": "1.5.0-rc2-24027",
339339
"Newtonsoft.Json": "7.0.1",

0 commit comments

Comments
 (0)