Send named pipe name to roslyn and razor (#7273)

Use named pipes to communicate between roslyn and razor processes for project information. 

Update Roslyn to: dnceng.visualstudio.com/internal/_build/results?buildId=2491728&view=results
Update Razor to: dev.azure.com/dnceng/internal/_build/results?buildId=2484091&view=results

Author: Andrew Hall

CHANGELOG.md

@@ -4,6 +4,32 @@
 - Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)
 
 # Latest
+* Update Razor to 9.0.0-preview.24327.6 (PR: [#7273](https://github.com/dotnet/vscode-csharp/pull/7273))
+  * Use a named pipe to communicate projectinfo in vscode (PR: [#10521](https://github.com/dotnet/razor/pull/10521))
+  * Reduce allocations in Razor's DirectiveVisitor (PR: [10521](https://github.com/dotnet/razor/pull/10521))
+* Update Roslyn to 4.12.0-1.24359.8 (PR: [#7273](https://github.com/dotnet/vscode-csharp/pull/7273))
+  * Fix UseNullPropagationCodeFixProvider for parenthesized property access (PR: [#74316](https://github.com/dotnet/roslyn/pull/74316))
+  * Sync solution contents consistently(PR: [#72860](https://github.com/dotnet/roslyn/pull/72860))
+  * Rename the record parameter when its property get renamed (PR: [#74168](https://github.com/dotnet/roslyn/pull/74168))
+  * Make project system workspace transformation functions resilient to being attempted twice (PR: [#74189](https://github.com/dotnet/roslyn/pull/74189))
+  * Report a diagnostic on missing body in partial property implementation (PR [#74224](https://github.com/dotnet/roslyn/pull/74224))
+  * Do not offer 'convert' namespace when the ns has sibling types (PR [#74216](https://github.com/dotnet/roslyn/pull/74216)
+  * Consume new Razor EA (PR: [#74134](https://github.com/dotnet/roslyn/pull/74134))
+  * Report diagnostic for field and value in property accessors when used as primary expressions only (PR: [#74164](https://github.com/dotnet/roslyn/pull/74164))
+  * Ensure an empty run result doesn't throw when generators are present (PR: [#74034](https://github.com/dotnet/roslyn/pull/74034))
+  * Support navigating to an interceptor location when on an intercepted method call (PR: [#74006](https://github.com/dotnet/roslyn/pull/74006))
+  * Add type hints for collection expressions (PR: [#74051](https://github.com/dotnet/roslyn/pull/74051))
+  * Ensure source generated documents are up-to-date before analyzing EnC changes (PR: [#73989](https://github.com/dotnet/roslyn/pull/73989))
+  * Support goto-def taking you from an interceptor method to the location being intercepted (PR: [#73992](https://github.com/dotnet/roslyn/pull/73992))
+  * Various performance fixes
+    * Reduce closures allocated during invocation of CapturedSymbolReplacement.Replacement (PR: [#74258](https://github.com/dotnet/roslyn/pull/74258))
+    * Reduce allocations in SymbolDeclaredCompilationEvent (PR: [#74250](https://github.com/dotnet/roslyn/pull/74250))
+    * Reduce allocations in AbstractProjectExtensionProvider.FilterExtensions (PR [#74112](https://github.com/dotnet/roslyn/pull/74112))
+    * Avoid re-running all codeaction requests at low priority (PR: [#74083](https://github.com/dotnet/roslyn/pull/74083))
+    * Reduce time spent in ConflictResolver.Session.GetNodesOrTokensToCheckForConflicts (PR: [#74101](https://github.com/dotnet/roslyn/pull/74101))
+    * Avoid allocations in AbstractSyntaxIndex<>.GetIndexAsync( PR: [#74075](https://github.com/dotnet/roslyn/pull/74075))
+
+# 2.37.x
 * Bump xamltools to 17.12.35103.251 (PR: [#7309](https://github.com/dotnet/vscode-csharp/pull/7309))
   * Fixed issue with Exception type related to https://github.com/microsoft/vscode-dotnettools/issues/1247
 

package.json

@@ -37,9 +37,9 @@
     }
   },
   "defaults": {
-    "roslyn": "4.11.0-3.24320.2",
+    "roslyn": "4.12.0-1.24359.8",
     "omniSharp": "1.39.11",
-    "razor": "9.0.0-preview.24325.5",
+    "razor": "9.0.0-preview.24327.6",
     "razorOmnisharp": "7.0.0-preview.23363.1",
     "xamlTools": "17.12.35103.251"
   },

src/lsptoolshost/razorCommands.ts

@@ -133,8 +133,9 @@ export function registerRazorCommands(context: vscode.ExtensionContext, language
     // a project. We want to defer this work until necessary, so this command is called by the Razor document manager to tell
     // us when they need us to initialize the Razor things.
     context.subscriptions.push(
-        vscode.commands.registerCommand(razorInitializeCommand, async () => {
-            await languageServer.sendNotification('razor/initialize', {});
+        vscode.commands.registerCommand(razorInitializeCommand, async (pipeName) => {
+            // params object must match https://github.com/dotnet/roslyn/blob/325ec8d93f9a28701fdcacffb175d2b01c3ac682/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/RazorInitializeHandler.cs#L37
+            await languageServer.sendNotification('razor/initialize', { pipeName: pipeName });
         })
     );
 }

src/razor/src/document/razorDocumentManager.ts

@@ -19,6 +19,7 @@ import { RazorDocumentChangeKind } from './razorDocumentChangeKind';
 import { createDocument } from './razorDocumentFactory';
 import { razorInitializeCommand } from '../../../lsptoolshost/razorCommands';
 import { PlatformInformation } from '../../../shared/platform';
+import { generateUuid } from 'vscode-languageclient/lib/common/utils/uuid';
 
 export class RazorDocumentManager implements IRazorDocumentManager {
     public roslynActivated = false;
@@ -176,7 +177,11 @@ export class RazorDocumentManager implements IRazorDocumentManager {
         // a Razor file.
         if (this.roslynActivated && !this.razorDocumentGenerationInitialized) {
             this.razorDocumentGenerationInitialized = true;
-            vscode.commands.executeCommand(razorInitializeCommand);
+            const pipeName = generateUuid();
+
+            vscode.commands.executeCommand(razorInitializeCommand, pipeName);
+            this.serverClient.connectNamedPipe(pipeName);
+
             for (const document of this.documents) {
                 await this.ensureDocumentAndProjectedDocumentsOpen(document);
             }

src/razor/src/razorLanguageServerClient.ts

@@ -150,6 +150,14 @@ export class RazorLanguageServerClient implements vscode.Disposable {
         return this.client.sendRequest<TResponseType>(method, param);
     }
 
+    public async sendNotification(method: string, param: any) {
+        if (!this.isStarted) {
+            throw new Error(vscode.l10n.t('Tried to send requests while server is not started.'));
+        }
+
+        return this.client.sendNotification(method, param);
+    }
+
     public async onRequestWithParams<P, R, E>(method: RequestType<P, R, E>, handler: RequestHandler<P, R, E>) {
         if (!this.isStarted) {
             throw new Error(vscode.l10n.t('Tried to bind on request logic while server is not started.'));
@@ -210,6 +218,13 @@ export class RazorLanguageServerClient implements vscode.Disposable {
         return this.stopHandle;
     }
 
+    public async connectNamedPipe(pipeName: string): Promise<void> {
+        await this.startHandle;
+
+        // Params must match https://github.com/dotnet/razor/blob/92005deac54f3e9d1a4d1d8f04389379cccfa354/src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Protocol/RazorNamedPipeConnectParams.cs#L9
+        await this.sendNotification('razor/namedPipeConnect', { pipeName: pipeName });
+    }
+
     private setupLanguageServer() {
         const languageServerTrace = resolveRazorLanguageServerLogLevel(this.vscodeType);
         const options: RazorLanguageServerOptions = resolveRazorLanguageServerOptions(
@@ -240,8 +255,6 @@ export class RazorLanguageServerClient implements vscode.Disposable {
 
         // TODO: When all of this code is on GitHub, should we just pass `--omnisharp` as a flag to rzls, and let it decide?
         if (!options.usingOmniSharp) {
-            args.push('--projectConfigurationFileName');
-            args.push('project.razor.vscode.bin');
             args.push('--DelegateToCSharpOnDiagnosticPublish');
             args.push('true');
             args.push('--UpdateBuffersForClosedDocuments');

test/integrationTests/completion.integration.test.ts

@@ -41,6 +41,11 @@ describe(`[${testAssetWorkspace.description}] Test Completion`, function () {
         const methodOverrideItem = completionList.items.find(
             (item) => item.label === 'Method(singleCsproj2.NeedsImport n)'
         );
+
+        if (!methodOverrideItem) {
+            throw new Error(completionList.items.reduce((acc, item) => acc + item.label + '\n', ''));
+        }
+
         expect(methodOverrideItem).toBeDefined();
         expect(methodOverrideItem!.kind).toEqual(vscode.CompletionItemKind.Method);
         expect(methodOverrideItem!.command).toBeDefined();