Skip to content

Commit 563e122

Browse files
committed
Rename project id and change key binding
1 parent 469523a commit 563e122

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -837,8 +837,8 @@
837837
"keybindings": [
838838
{
839839
"command": "o.showOutput",
840-
"key": "Ctrl+L L",
841-
"mac": "Cmd+L L"
840+
"key": "Ctrl+Shift+F9",
841+
"mac": "Cmd+Shift+F9"
842842
},
843843
{
844844
"command": "csharp.setNextStatement",

src/observers/TelemetryObserver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export class TelemetryObserver {
4646
break;
4747
case EventType.ProjectConfigurationReceived:
4848
let projectConfig = (<ProjectConfiguration>event).projectConfiguration;
49-
telemetryProps['ProjectId'] = projectConfig.ProjectGuid;
49+
telemetryProps['ProjectId'] = projectConfig.ProjectId;
5050
telemetryProps['TargetFrameworks'] = projectConfig.TargetFrameworks.join("|");
5151
telemetryProps['References'] = projectConfig.References.join("|");
5252
telemetryProps['FileExtensions'] = projectConfig.FileExtensions.join("|");

src/omnisharp/protocol.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ export interface UnresolvedDependenciesMessage {
431431
}
432432

433433
export interface ProjectConfigurationMessage {
434-
ProjectGuid: string;
434+
ProjectId: string;
435435
TargetFrameworks: string[];
436436
References: string[];
437437
FileExtensions: string[];

test/unitTests/logging/TelemetryObserver.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ suite('TelemetryReporterObserver', () => {
4949
expect(property).to.have.property("installStage", "completeSuccess");
5050
});
5151

52-
test(`${ProjectConfiguration.name}: Telemetry props contains project file path and target framework`, () => {
52+
test(`${ProjectConfiguration.name}: Telemetry props contains project id and target framework`, () => {
5353
const targetFrameworks = new Array("tfm1", "tfm2");
54-
const projectId = "projectFilePath";
54+
const projectId = "sample";
5555
const references = new Array("ref1", "ref2");
5656
const fileExtensions = new Array(".cs", ".cshtml");
5757
let event = new ProjectConfiguration({
5858
TargetFrameworks: targetFrameworks,
59-
ProjectGuid: projectId,
59+
ProjectId: projectId,
6060
References: references,
6161
FileExtensions: fileExtensions
6262
});

0 commit comments

Comments
 (0)