Skip to content

Commit 57edd5f

Browse files
Don't specify 'proxy' and 'strictSSL' as optional arguments as they aren't used as such by TypeScript
1 parent fd1a367 commit 57edd5f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/packages.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ function getNoopStatus(): Status {
128128
};
129129
}
130130

131-
function downloadPackage(pkg: Package, logger: Logger, status?: Status, proxy?: string, strictSSL?: boolean): Promise<void> {
131+
function downloadPackage(pkg: Package, logger: Logger, status: Status, proxy: string, strictSSL: boolean): Promise<void> {
132132
status = status || getNoopStatus();
133133

134134
logger.append(`Downloading package '${pkg.description}' `);
@@ -152,7 +152,7 @@ function downloadPackage(pkg: Package, logger: Logger, status?: Status, proxy?:
152152
});
153153
}
154154

155-
function downloadFile(urlString: string, pkg: Package, logger: Logger, status: Status, proxy?: string, strictSSL?: boolean): Promise<void> {
155+
function downloadFile(urlString: string, pkg: Package, logger: Logger, status: Status, proxy: string, strictSSL: boolean): Promise<void> {
156156
const url = parseUrl(urlString);
157157

158158
const options: https.RequestOptions = {

src/proxy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function getSystemProxyURL(requestURL: Url): string {
1919
return null;
2020
}
2121

22-
export function getProxyAgent(requestURL: Url, proxy?: string, strictSSL?: boolean): any {
22+
export function getProxyAgent(requestURL: Url, proxy: string, strictSSL: boolean): any {
2323
const proxyURL = proxy || getSystemProxyURL(requestURL);
2424

2525
if (!proxyURL) {

0 commit comments

Comments
 (0)