More lint

Author: dibarbet

.eslintrc.js

@@ -24,6 +24,7 @@ module.exports = {
                 "caughtErrorsIgnorePattern": "^_"
             }
         ],
+        "@typescript-eslint/no-namespace": "off"
     },
     ignorePatterns: [
         "out/",

package-lock.json

@@ -136,9 +136,10 @@
     "js-yaml": ">=3.13.1",
     "minimatch": "3.0.5",
     "mocha": "10.0.0",
-    "mock-fs": "4.13.0",
+    "mock-fs": "^4.13.0",
     "mock-http-server": "1.4.2",
     "rimraf": "2.6.3",
+    "source-map-support": "^0.5.21",
     "ts-loader": "9.0.0",
     "ts-node": "9.1.1",
     "tslint": "5.12.1",
@@ -862,17 +863,17 @@
                     "items": {
                       "type": "string"
                     },
-                    "description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
+                    "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
                     "default": []
                   },
                   "searchMicrosoftSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "searchNuGetOrgSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "cachePath": {
@@ -1504,17 +1505,17 @@
             "items": {
               "type": "string"
             },
-            "description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
+            "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
             "default": []
           },
           "csharp.debug.symbolOptions.searchMicrosoftSymbolServer": {
             "type": "boolean",
-            "description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+            "description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
             "default": false
           },
           "csharp.debug.symbolOptions.searchNuGetOrgSymbolServer": {
             "type": "boolean",
-            "description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+            "description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
             "default": false
           },
           "csharp.debug.symbolOptions.cachePath": {
@@ -2257,17 +2258,17 @@
                     "items": {
                       "type": "string"
                     },
-                    "description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
+                    "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
                     "default": []
                   },
                   "searchMicrosoftSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "searchNuGetOrgSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "cachePath": {
@@ -2697,17 +2698,17 @@
                     "items": {
                       "type": "string"
                     },
-                    "description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
+                    "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
                     "default": []
                   },
                   "searchMicrosoftSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "searchNuGetOrgSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "cachePath": {
@@ -3411,17 +3412,17 @@
                     "items": {
                       "type": "string"
                     },
-                    "description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
+                    "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
                     "default": []
                   },
                   "searchMicrosoftSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "searchNuGetOrgSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "cachePath": {
@@ -3851,17 +3852,17 @@
                     "items": {
                       "type": "string"
                     },
-                    "description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
+                    "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
                     "default": []
                   },
                   "searchMicrosoftSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "searchNuGetOrgSymbolServer": {
                     "type": "boolean",
-                    "description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
+                    "description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
                     "default": false
                   },
                   "cachePath": {
@@ -4864,4 +4865,4 @@
       }
     ]
   }
-}
+}

package.json

@@ -7,35 +7,30 @@
 // property on a launch or attach request.
 //
 // All messages are sent as UTF-8 JSON text with a tailing '\n'
-export namespace DebuggerEventsProtocol {
-    export namespace EventType {
-        // Indicates that the vsdbg-ui has received the attach or launch request and is starting up
-        export const Starting = "starting";
-        // Indicates that vsdbg-ui has successfully launched the specified process.
-        // The ProcessLaunchedEvent interface details the event payload.
-        export const ProcessLaunched = "processLaunched";
-        // Debug session is ending
-        export const DebuggingStopped = "debuggingStopped";
-    }
+export const Starting = "starting";
+// Indicates that vsdbg-ui has successfully launched the specified process.
+// The ProcessLaunchedEvent interface details the event payload.
+export const ProcessLaunched = "processLaunched";
+// Debug session is ending
+export const DebuggingStopped = "debuggingStopped";
 
-    export interface DebuggerEvent {
-        // Contains one of the 'DebuggerEventsProtocol.EventType' values
-        eventType: string;
-    }
+export interface DebuggerEvent {
+    // Contains one of the 'DebuggerEventsProtocol.EventType' values
+    eventType: string;
+}
 
-    export interface ProcessLaunchedEvent extends DebuggerEvent {
-        // Process id of the newly-launched target process
-        targetProcessId: number;
-    }
+export interface ProcessLaunchedEvent extends DebuggerEvent {
+    // Process id of the newly-launched target process
+    targetProcessId: number;
+}
 
-    // Decodes a packet received from the debugger into an event
-    export function decodePacket(packet: Buffer): DebuggerEvent {
-        // Verify the message ends in a newline
-        if (packet[packet.length - 1] != 10 /*\n*/) {
-            throw new Error("Unexpected message received from debugger.");
-        }
-
-        const message = packet.toString('utf-8', 0, packet.length - 1);
-        return JSON.parse(message);
+// Decodes a packet received from the debugger into an event
+export function decodePacket(packet: Buffer): DebuggerEvent {
+    // Verify the message ends in a newline
+    if (packet[packet.length - 1] != 10 /*\n*/) {
+        throw new Error("Unexpected message received from debugger.");
     }
+
+    const message = packet.toString('utf-8', 0, packet.length - 1);
+    return JSON.parse(message);
 }

src/coreclr-debug/debuggerEventsProtocol.ts

@@ -100,7 +100,7 @@ export default class OmniSharpCodeLensProvider extends AbstractProvider implemen
                 return createCodeLenses(response.Elements, document.fileName, options);
             }
         }
-        catch (error) { }
+        catch (error) { /* empty */ }
 
         return [];
     }

src/features/codeLensProvider.ts

@@ -11,7 +11,7 @@ import * as serverUtils from "../omnisharp/utils";
 import * as utils from '../common';
 import * as vscode from 'vscode';
 import AbstractProvider from './abstractProvider';
-import { DebuggerEventsProtocol } from '../coreclr-debug/debuggerEventsProtocol';
+import * as DebuggerEventsProtocol from '../coreclr-debug/debuggerEventsProtocol';
 import { OmniSharpServer } from '../omnisharp/server';
 import { TestExecutionCountReport, ReportDotNetTestResults, DotNetTestRunStart, DotNetTestMessage, DotNetTestRunFailure, DotNetTestsInClassRunStart, DotNetTestDebugWarning, DotNetTestDebugProcessStart, DotNetTestDebugComplete, DotNetTestDebugStart, DotNetTestsInClassDebugStart, DotNetTestDebugStartFailure, DotNetTestRunInContextStart, DotNetTestDebugInContextStart } from '../omnisharp/loggingEvents';
 import { EventStream } from '../EventStream';
@@ -182,7 +182,7 @@ export default class TestManager extends AbstractProvider {
             const response = await serverUtils.discoverTests(this._server, request);
             return response.Tests;
         }
-        catch {}
+        catch { /* empty */ }
 
         return undefined;
     }
@@ -586,13 +586,14 @@ class DebugEventListener {
                 }
 
                 switch (event.eventType) {
-                    case DebuggerEventsProtocol.EventType.ProcessLaunched:
+                    case DebuggerEventsProtocol.ProcessLaunched: {
                         const processLaunchedEvent = <DebuggerEventsProtocol.ProcessLaunchedEvent>(event);
                         this._eventStream.post(new DotNetTestDebugProcessStart(processLaunchedEvent.targetProcessId));
                         this.onProcessLaunched(processLaunchedEvent.targetProcessId);
                         break;
+                    }
 
-                    case DebuggerEventsProtocol.EventType.DebuggingStopped:
+                    case DebuggerEventsProtocol.DebuggingStopped:
                         this._eventStream.post(new DotNetTestDebugComplete());
                         this.onDebuggingStopped();
                         break;

src/features/dotnetTest.ts

@@ -20,7 +20,7 @@ export default class OmniSharpImplementationProvider extends AbstractSupport imp
             // Allow language middlewares to re-map its edits if necessary.
             const result = await this._languageMiddlewareFeature.remap("remapLocations", implementations, token);
             return result;
-        } catch {}
+        } catch { /* empty */ }
 
         return undefined;
     }