Skip to content

Commit 5acd3f7

Browse files
Fix description of debugger console setting (#6726)
This PR updates the description of the `console` debugger setting. Improvements made: * The launch.json setting is applicable to all project types, so don't indicate it only applies to console projects * Update wording to match what we have in the documentation * Add a link to the documentation * Don't incorrectly indicate that `internalConsole` doesn't support reading from the console. This PR also increases the max VSIX size to get PR builds working again. A node upgrade (18.18.2 -> 18.19.0) seems to have pushed us over the limit.
1 parent 842739f commit 5acd3f7

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

package.nls.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,16 +188,16 @@
188188
"Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered."
189189
]
190190
},
191-
"generateOptionsSchema.console.markdownDescription": "When launching console projects, indicates which console the target program should be launched into.",
191+
"generateOptionsSchema.console.markdownDescription": "Indicates which console the target program should be launched into. See https://aka.ms/VSCode-CS-LaunchJson-Console for more information.",
192192
"generateOptionsSchema.console.settingsDescription": {
193-
"message": "**Note:** _This option is only used for the `dotnet` debug configuration type_.\n\nWhen launching console projects, indicates which console the target program should be launched into.",
193+
"message": "**Note:** _This option is only used for console projects launched with the `dotnet` debug configuration type_.\n\nIndicates which console the target program should be launched into. See https://aka.ms/VSCode-CS-LaunchJson-Console for more information.",
194194
"comment": [
195195
"Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered."
196196
]
197197
},
198-
"generateOptionsSchema.console.internalConsole.enumDescription": "Output to the VS Code Debug Console. This doesn't support reading console input (ex:Console.ReadLine).",
199-
"generateOptionsSchema.console.integratedTerminal.enumDescription": "VS Code's integrated terminal.",
200-
"generateOptionsSchema.console.externalTerminal.enumDescription": "External terminal that can be configured via user settings.",
198+
"generateOptionsSchema.console.internalConsole.enumDescription": "The target process's console input (stdin) and output (stdout/stderr) are routed through the VS Code Debug Console.",
199+
"generateOptionsSchema.console.integratedTerminal.enumDescription": "The target process will run inside VS Code's integrated terminal.",
200+
"generateOptionsSchema.console.externalTerminal.enumDescription": "The target process will run inside its own external terminal. When using this mode, you will need to switch focus between Visual Studio Code and the external terminal window.",
201201
"generateOptionsSchema.externalConsole.markdownDescription": {
202202
"message": "Attribute `externalConsole` is deprecated, use `console` instead. This option defaults to `false`.",
203203
"comment": [

src/tools/OptionsSchema.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -371,12 +371,12 @@
371371
"type": "string",
372372
"enum": [ "internalConsole", "integratedTerminal", "externalTerminal" ],
373373
"enumDescriptions": [
374-
"Output to the VS Code Debug Console. This doesn't support reading console input (ex:Console.ReadLine).",
375-
"VS Code's integrated terminal.",
376-
"External terminal that can be configured via user settings."
374+
"The target process's console input (stdin) and output (stdout/stderr) are routed through the VS Code Debug Console.",
375+
"The target process will run inside VS Code's integrated terminal.",
376+
"The target process will run inside its own external terminal. When using this mode, you will need to switch focus between Visual Studio Code and the external terminal window."
377377
],
378-
"markdownDescription": "When launching console projects, indicates which console the target program should be launched into.",
379-
"settingsDescription": "**Note:** _This option is only used for the `dotnet` debug configuration type_.\n\nWhen launching console projects, indicates which console the target program should be launched into.",
378+
"markdownDescription": "Indicates which console the target program should be launched into. See https://aka.ms/VSCode-CS-LaunchJson-Console for more information.",
379+
"settingsDescription": "**Note:** _This option is only used for console projects launched with the `dotnet` debug configuration type_.\n\nIndicates which console the target program should be launched into. See https://aka.ms/VSCode-CS-LaunchJson-Console for more information.",
380380
"default": "internalConsole"
381381
},
382382
"externalConsole": {

test/artifactTests/vsix.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('Vscode VSIX', () => {
1818
vsixFiles.forEach((element) => {
1919
// We're packaging the platform specific Roslyn server with ready to run in the vsix, so the size should be roughly ~50MB
2020
// We also publish the Razor server, which is roughly ~75MB
21-
const sizeInMB = 220;
21+
const sizeInMB = 230;
2222
const maximumVsixSizeInBytes = sizeInMB * 1024 * 1024;
2323

2424
describe(`Given ${element}`, () => {

0 commit comments

Comments
 (0)