Fix tests

Author: winstliu

test/unitTests/OmnisharpPackageCreator.test.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { assert, should, expect } from "chai";
+import { assert, should } from "chai";
 import { SetBinaryAndGetPackage, GetPackagesFromVersion, modernNetVersion } from "../../src/omnisharp/OmnisharpPackageCreator";
 import { Package } from "../../src/packageManager/Package";
 import { testPackageJSON } from "./testAssets/testAssets";
@@ -29,26 +29,13 @@ suite("GetOmnisharpPackage : Output package depends on the input package and oth
     useFrameworkOptions.forEach((useFramework) => {
         const pathSuffix = useFramework ? '' : `-net${modernNetVersion}`;
 
-        test(`Throws exception if version is empty useFramework: ${useFramework}`, () => {
-            let testPackage = inputPackages.find(element => (element.platformId && element.platformId == "os-architecture"));
-            let fn = function () { SetBinaryAndGetPackage(testPackage, useFramework, serverUrl, "", installPath); };
-            expect(fn).to.throw('Invalid version');
-        });
-
-        test(`Throws exception if version is null useFramework: ${useFramework}`, () => {
-            let testPackage = inputPackages.find(element => (element.platformId && element.platformId == "os-architecture"));
-            let fn = function () { SetBinaryAndGetPackage(testPackage, useFramework, serverUrl, null, installPath); };
-            expect(fn).to.throw('Invalid version');
-        });
-
-        test(`Architectures, binaries and platforms do not change and fallback url is empty useFramework: ${useFramework}`, () => {
+        test(`Architectures, binaries and platforms do not change useFramework: ${useFramework}`, () => {
             let testPackage = inputPackages.find(element => (element.platformId && element.platformId == "os-architecture"));
             let resultPackage = SetBinaryAndGetPackage(testPackage, useFramework, serverUrl, version, installPath);
 
             resultPackage.architectures.should.equal(testPackage.architectures);
             assert.equal(resultPackage.binaries, testPackage.binaries);
             resultPackage.platforms.should.equal(testPackage.platforms);
-            expect(resultPackage.fallbackUrl).to.be.undefined;
         });
 
         test(`Version information is appended to the description useFramework: ${useFramework}`, () => {
@@ -112,26 +99,8 @@ suite('GetPackagesFromVersion : Gets the experimental omnisharp packages from a
 
     const serverUrl = "http://serverUrl";
     const installPath = "testPath";
-    let inputPackages: any;
-
-    suiteSetup(() => {
-        inputPackages = <Package[]>(testPackageJSON.runtimeDependencies);
-        should();
-    });
 
     [true, false].forEach((useFramework) => {
-        test(`Throws exception if the version is null (useFramework: ${useFramework})`, () => {
-            let version: string = null;
-            let fn = function () { GetPackagesFromVersion(version, useFramework, inputPackages, serverUrl, installPath); };
-            expect(fn).to.throw('Invalid version');
-        });
-
-        test(`Throws exception if the version is empty (useFramework: ${useFramework})`, () => {
-            let version = "";
-            let fn = function () { GetPackagesFromVersion(version, useFramework, inputPackages, serverUrl, installPath); };
-            expect(fn).to.throw('Invalid version');
-        });
-
         test('Returns experiment packages with install test path depending on install path and version', () => {
             let inputPackages: Package[] = [
                 {