Remove OmniSharp decompilation acknowledgment prompt.

Author: JoeRobich

src/features/commands.ts

@@ -26,7 +26,6 @@ import CompositeDisposable from '../compositeDisposable';
 import reportIssue from '../shared/reportIssue';
 import { IHostExecutableResolver } from '../shared/constants/IHostExecutableResolver';
 import { getDotnetInfo } from '../shared/utils/getDotnetInfo';
-import { getDecompilationAuthorization, resetDecompilationAuthorization } from '../omnisharp/decompilationPrompt';
 import { IWorkspaceDebugInformationProvider } from '../shared/IWorkspaceDebugInformationProvider';
 
 export default function registerCommands(
@@ -78,26 +77,10 @@ export default function registerCommands(
         )
     );
 
-    disposable.add(
-        vscode.commands.registerCommand('csharp.showDecompilationTerms', async () =>
-            showDecompilationTerms(context, server)
-        )
-    );
-
     return new CompositeDisposable(disposable);
 }
 
-async function showDecompilationTerms(context: vscode.ExtensionContext, server: OmniSharpServer) {
-    // Reset the decompilation authorization so the user will be prompted on restart.
-    resetDecompilationAuthorization(context);
-
-    await restartOmniSharp(context, server);
-}
-
 async function restartOmniSharp(context: vscode.ExtensionContext, server: OmniSharpServer) {
-    // Update decompilation authorization.
-    server.decompilationAuthorized = await getDecompilationAuthorization(context);
-
     if (server.isRunning()) {
         server.restart();
     } else {

src/omnisharp/decompilationPrompt.ts

@@ -20,7 +20,6 @@ import Disposable from '../disposable';
 import { OmniSharpMonoResolver } from './omniSharpMonoResolver';
 import { getMonoVersion } from '../utils/getMonoVersion';
 import { LanguageMiddlewareFeature } from './languageMiddlewareFeature';
-import { getDecompilationAuthorization } from './decompilationPrompt';
 import { DotnetResolver } from './dotnetResolver';
 import { Advisor } from '../features/diagnosticsProvider';
 import { OmnisharpWorkspaceDebugInformationProvider } from '../omnisharpWorkspaceDebugInformationProvider';
@@ -50,8 +49,6 @@ export async function activate(
     languageMiddlewareFeature.register();
     disposables.add(languageMiddlewareFeature);
 
-    const decompilationAuthorized = await getDecompilationAuthorization(context);
-
     const server = new OmniSharpServer(
         vscode,
         provider,
@@ -61,7 +58,6 @@ export async function activate(
         extensionPath,
         omnisharpMonoResolver,
         omnisharpDotnetResolver,
-        decompilationAuthorized,
         context,
         outputChannel,
         languageMiddlewareFeature

src/omnisharp/extension.ts

@@ -115,7 +115,6 @@ export class OmniSharpServer {
         private extensionPath: string,
         private monoResolver: IHostExecutableResolver,
         private dotnetResolver: IHostExecutableResolver,
-        public decompilationAuthorized: boolean,
         private context: ExtensionContext,
         private outputChannel: OutputChannel,
         private languageMiddlewareFeature: LanguageMiddlewareFeature
@@ -463,7 +462,7 @@ export class OmniSharpServer {
             args.push('FormattingOptions:OrganizeImports=true');
         }
 
-        if (this.decompilationAuthorized && omnisharpOptions.enableDecompilationSupport === true) {
+        if (omnisharpOptions.enableDecompilationSupport === true) {
             args.push('RoslynExtensionsOptions:EnableDecompilationSupport=true');
         }