Skip to content

Commit 5da74fe

Browse files
Merge pull request #109 from caslan/fixerrormessages2
Improve debugger install error messages
2 parents a7fb6fb + d0f0c4b commit 5da74fe

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"run-in-terminal": "*",
2626
"semver": "*",
2727
"vscode-extension-telemetry": "0.0.4",
28-
"tmp": "0.0.28"
28+
"tmp": "0.0.28",
29+
"open": "*"
2930
},
3031
"devDependencies": {
3132
"gulp": "^3.9.1",

src/coreclr-debug.ts

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,15 @@ export function installCoreClrDebug(context: vscode.ExtensionContext) {
2727
}
2828

2929
if (!isOnPath('dotnet')) {
30-
// TODO: In a future release, this should be an error. For this release, we will let it go
31-
console.log("The .NET CLI tools are not installed. .NET Core debugging will not be enabled.");
30+
const getDotNetMessage = "Get .NET CLI tools";
31+
vscode.window.showErrorMessage("The .NET CLI tools cannot be located. .NET Core debugging will not be enabled. Make sure .NET CLI tools are installed and are on the path.",
32+
getDotNetMessage).then(function (value) {
33+
if (value === getDotNetMessage) {
34+
var open = require('open');
35+
open("http://dotnet.github.io/getting-started/");
36+
}
37+
});
38+
3239
return;
3340
}
3441

@@ -45,9 +52,8 @@ export function installCoreClrDebug(context: vscode.ExtensionContext) {
4552
};
4653
})();
4754

48-
_channel.appendLine("Downloading and configuring the .NET Core Debugger...");
49-
_channel.show(vscode.ViewColumn.Three);
50-
55+
vscode.window.setStatusBarMessage("Downloading and configuring the .NET Core Debugger...");
56+
5157
let installStage = 'dotnet restore';
5258
let installError = '';
5359

@@ -71,10 +77,15 @@ export function installCoreClrDebug(context: vscode.ExtensionContext) {
7177
return writeCompletionFile();
7278
}).then(function() {
7379
installStage = "completeSuccess";
74-
_channel.appendLine('Succesfully installed .NET Core Debugger.');
80+
vscode.window.setStatusBarMessage('Successfully installed .NET Core Debugger.');
7581
})
7682
.catch(function(error) {
77-
_channel.appendLine('Error while installing .NET Core Debugger.');
83+
const viewLogMessage = "View Log";
84+
vscode.window.showErrorMessage('Error while installing .NET Core Debugger.', viewLogMessage).then(function (value) {
85+
if (value === viewLogMessage) {
86+
_channel.show(vscode.ViewColumn.Three);
87+
}
88+
})
7889

7990
installError = error.toString();
8091
console.log(error);

0 commit comments

Comments
 (0)