Merge pull request #1995 from rchande/omnisharp1.29

Update to omnisharp 1.29

Author: Ravi Chande

package.json

@@ -84,8 +84,8 @@
   "runtimeDependencies": [
     {
       "description": "OmniSharp for Windows (.NET 4.6 / x86)",
-      "url": "https://download.visualstudio.microsoft.com/download/pr/100505823/5804b7d3b5eeb7e4ae812a7cff03bd52/omnisharp-win-x86-1.28.0.zip",
-      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x86-1.28.0.zip",
+      "url": "https://download.visualstudio.microsoft.com/download/pr/11539709/dcb3a815e48ea792fc788fc9fa6ea379/omnisharp-win-x86-1.29.0.zip",
+      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x86-1.29.0.zip",
       "installPath": ".omnisharp",
       "platforms": [
         "win32"
@@ -97,8 +97,8 @@
     },
     {
       "description": "OmniSharp for Windows (.NET 4.6 / x64)",
-      "url": "https://download.visualstudio.microsoft.com/download/pr/100505821/c570a9e20dbf7172f79850babd058872/omnisharp-win-x64-1.28.0.zip",
-      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x64-1.28.0.zip",
+      "url": "https://download.visualstudio.microsoft.com/download/pr/11539712/2ceb65cab39ffc725480ede21ad8071c/omnisharp-win-x64-1.29.0.zip",
+      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x64-1.29.0.zip",
       "installPath": ".omnisharp",
       "platforms": [
         "win32"
@@ -110,8 +110,8 @@
     },
     {
       "description": "OmniSharp for OSX",
-      "url": "https://download.visualstudio.microsoft.com/download/pr/100505818/6b99c6a86da3221919158ca0f36a3e45/omnisharp-osx-1.28.0.zip",
-      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-osx-1.28.0.zip",
+      "url": "https://download.visualstudio.microsoft.com/download/pr/11539710/5594f85f23035c42f0893f61a19f2340/omnisharp-osx-1.29.0.zip",
+      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-osx-1.29.0.zip",
       "installPath": ".omnisharp",
       "platforms": [
         "darwin"
@@ -124,8 +124,8 @@
     },
     {
       "description": "OmniSharp for Linux (x86)",
-      "url": "https://download.visualstudio.microsoft.com/download/pr/100505817/b710ec9c2bedc0cfdb57da82da166c47/omnisharp-linux-x86-1.28.0.zip",
-      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-linux-x86-1.28.0.zip",
+      "url": "https://download.visualstudio.microsoft.com/download/pr/11539707/ffe833a2a771adead00c977fe9b0a8ea/omnisharp-linux-x86-1.29.0.zip",
+      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-linux-x86-1.29.0.zip",
       "installPath": ".omnisharp",
       "platforms": [
         "linux"
@@ -142,8 +142,8 @@
     },
     {
       "description": "OmniSharp for Linux (x64)",
-      "url": "https://download.visualstudio.microsoft.com/download/pr/100505485/3f8a10409240decebb8a3189429f3fdf/omnisharp-linux-x64-1.28.0.zip",
-      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-linux-x64-1.28.0.zip",
+      "url": "https://download.visualstudio.microsoft.com/download/pr/11539705/289061d8686d4689d66fd1610b6891e2/omnisharp-linux-x64-1.29.0.zip",
+      "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-linux-x64-1.29.0.zip",
       "installPath": ".omnisharp",
       "platforms": [
         "linux"

test/integrationTests/codeActionRename.integration.test.ts

@@ -30,9 +30,12 @@ suite(`Code Action Rename ${testAssetWorkspace.description}`, function() {
     test("Code actions can remame and open files", async () => {                
         let fileUri = await testAssetWorkspace.projects[0].addFileWithContents("test.cs", "class C {}");
         await vscode.commands.executeCommand("vscode.open", fileUri);
-        let c = await vscode.commands.executeCommand("vscode.executeCodeActionProvider", fileUri, new vscode.Range(0, 7, 0, 7)) as {command: string, arguments: string[]}[];
-        expect(c.length).to.equal(2);
-        await vscode.commands.executeCommand(c[1].command, ...c[1].arguments)
+        let c = await vscode.commands.executeCommand("vscode.executeCodeActionProvider", fileUri, new vscode.Range(0, 7, 0, 7)) as {command: string, title: string, arguments: string[]}[];
+        let command = c.find(
+            (s) => { return s.title == "Rename file to C.cs" }
+        )
+        expect(command, "Didn't find rename class command");
+        await vscode.commands.executeCommand(command.command, ...command.arguments)
         expect(vscode.window.activeTextEditor.document.fileName).contains("C.cs");
     });
 }); 

test/integrationTests/hoverProvider.integration.test.ts

@@ -72,12 +72,11 @@ Parameters:
 \t\tgameObject: The game object.
 \t\ttagName: Name of the tag.
 
-Returns trueif object is tagged with tag.`;
+Returns  true if object is tagged with tag.`;
        expect(c[0].contents[0].value).to.equal(answer);
     });
 
-    teardown(async() =>
-    {   
-        await testAssetWorkspace.cleanupWorkspace();     
-    })
+    teardown(async () => {
+        await testAssetWorkspace.cleanupWorkspace();
+    });
 });