Manage information diagnostic severity on the client-side.

- A server-side change is being made to report diagnostics with their reported severity.
- This adds client-side middleware to allow users who prefer to not see information diagnostics in their editor have those diagnostics be reproted as hint.

Author: JoeRobich

package-lock.json

@@ -116,10 +116,11 @@
     "tmp": "0.0.33",
     "uuid": "^9.0.0",
     "vscode-html-languageservice": "^5.0.1",
-    "vscode-jsonrpc": "8.2.0-next.0",
-    "vscode-languageclient": "8.2.0-next.1",
-    "vscode-languageserver-protocol": "3.17.4-next.1",
-    "vscode-languageserver-textdocument": "^1.0.5",
+    "vscode-jsonrpc": "9.0.0-next.7",
+    "vscode-languageclient": "10.0.0-next.14",
+    "vscode-languageserver-protocol": "3.17.6-next.12",
+    "vscode-languageserver-textdocument": "1.0.12",
+    "vscode-languageserver-types": "3.17.6-next.6",
     "vscode-nls": "5.0.1",
     "yauzl": "2.10.0"
   },
@@ -169,7 +170,9 @@
     "ts-jest": "^29.1.1",
     "ts-loader": "9.0.0",
     "ts-node": "9.1.1",
+    "tsconfig-paths-webpack-plugin": "^4.2.0",
     "typescript": "5.6.2",
+    "umd-compat-loader": "2.1.2",
     "unzipper": "0.10.11",
     "vscode-oniguruma": "^1.6.1",
     "vscode-textmate": "^6.0.0",
@@ -839,6 +842,12 @@
             "description": "%configuration.dotnet.backgroundAnalysis.compilerDiagnosticsScope%",
             "order": 30
           },
+          "dotnet.diagnostics.reportInformationAsHint": {
+            "type": "boolean",
+            "default": false,
+            "description": "%configuration.dotnet.diagnostics.reportInformationAsHint%",
+            "order": 30
+          },
           "dotnet.highlighting.highlightRelatedRegexComponents": {
             "type": "boolean",
             "default": "true",

package.json

@@ -61,6 +61,7 @@
   "configuration.dotnet.backgroundAnalysis.compilerDiagnosticsScope.openFiles": "Open documents",
   "configuration.dotnet.backgroundAnalysis.compilerDiagnosticsScope.fullSolution": "Entire solution",
   "configuration.dotnet.backgroundAnalysis.compilerDiagnosticsScope.none": "None",
+  "configuration.dotnet.diagnostics.reportInformationAsHint": "Enable this setting to reduce visual distractions in your editor. Information problems will be reported as hints and only be visible when the code actions popup is open.",
   "configuration.dotnet.highlighting.highlightRelatedRegexComponents": "Highlight related regular expression components under cursor.",
   "configuration.dotnet.highlighting.highlightRelatedJsonComponents": "Highlight related JSON components under cursor.",
   "configuration.csharp.inlayHints.enableInlayHintsForImplicitObjectCreation": "Show hints for implicit object creation",

package.nls.json

@@ -56,7 +56,7 @@ export class OnAutoInsertFeature implements DynamicFeature<RoslynProtocol.OnAuto
             this._registrations.delete(id);
         }
     }
-    dispose(): void {
+    clear(): void {
         this._registrations.clear();
     }
 

src/lsptoolshost/autoInsert/onAutoInsertFeature.ts

@@ -0,0 +1,42 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as vscode from 'vscode';
+import { ProvideDiagnosticSignature, ProvideWorkspaceDiagnosticSignature, vsdiag } from 'vscode-languageclient/node';
+import { languageServerOptions } from '../../shared/options';
+
+export async function provideDiagnostics(
+    document: vscode.TextDocument | vscode.Uri,
+    previousResultId: string | undefined,
+    token: vscode.CancellationToken,
+    next: ProvideDiagnosticSignature
+) {
+    const result = await next(document, previousResultId, token);
+    tryUpdateInformationDiagnostics(result);
+    return result;
+}
+
+export async function provideWorkspaceDiagnostics(
+    resultIds: vsdiag.PreviousResultId[],
+    token: vscode.CancellationToken,
+    resultReporter: vsdiag.ResultReporter,
+    next: ProvideWorkspaceDiagnosticSignature
+) {
+    const result = await next(resultIds, token, (chunk) => {
+        chunk?.items.forEach(tryUpdateInformationDiagnostics);
+        resultReporter(chunk);
+    });
+    return result;
+}
+
+function tryUpdateInformationDiagnostics(report: vsdiag.DocumentDiagnosticReport | null | undefined) {
+    if (report?.kind === vsdiag.DocumentDiagnosticReportKind.full && languageServerOptions.reportInformationAsHint) {
+        report.items.forEach((item) => {
+            if (item.severity === vscode.DiagnosticSeverity.Information) {
+                item.severity = vscode.DiagnosticSeverity.Hint;
+            }
+        });
+    }
+}

src/lsptoolshost/diagnostics/diagnosticMiddleware.ts

@@ -58,7 +58,7 @@ export async function getFixAllResponse(
 
                 if (response.edit) {
                     const uriConverter: URIConverter = (value: string): vscode.Uri => UriConverter.deserialize(value);
-                    const protocolConverter = createConverter(uriConverter, true, true);
+                    const protocolConverter = createConverter(uriConverter, true, true, true);
                     const fixAllEdit = await protocolConverter.asWorkspaceEdit(response.edit);
                     if (!(await vscode.workspace.applyEdit(fixAllEdit))) {
                         const componentName = '[roslyn.client.fixAllCodeAction]';

src/lsptoolshost/diagnostics/fixAllCodeAction.ts

@@ -75,7 +75,7 @@ async function registerNestedResolveCodeAction(
 
                         const uriConverter: URIConverter = (value: string): vscode.Uri =>
                             UriConverter.deserialize(value);
-                        const protocolConverter = createConverter(uriConverter, true, true);
+                        const protocolConverter = createConverter(uriConverter, true, true, true);
                         const fixAllEdit = await protocolConverter.asWorkspaceEdit(response.edit);
                         if (!(await vscode.workspace.applyEdit(fixAllEdit))) {
                             const componentName = '[roslyn.client.nestedCodeAction]';

src/lsptoolshost/diagnostics/nestedCodeAction.ts

@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 import * as vscode from 'vscode';
-import { RequestType } from 'vscode-languageclient/node';
+import { RequestType } from 'vscode-jsonrpc';
 import { RoslynLanguageServer } from '../server/roslynLanguageServer';
 
 export class RoslynLanguageServerExport {

src/lsptoolshost/extensions/roslynLanguageServerExportChannel.ts

@@ -27,7 +27,7 @@ import {
     InlayHintResolveRequest,
     InlayHintParams,
     InlayHintRequest,
-} from 'vscode-languageclient/node';
+} from 'vscode-languageclient';
 import SerializableSimplifyMethodParams from '../../razor/src/simplify/serializableSimplifyMethodParams';
 import { TextEdit } from 'vscode-html-languageservice';
 import { SerializableFormatNewFileParams } from '../../razor/src/formatNewFile/serializableFormatNewFileParams';

src/lsptoolshost/razor/razorCommands.ts

@@ -3,13 +3,9 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import {
-    CancellationToken,
-    LanguageClient,
-    LanguageClientOptions,
-    MessageSignature,
-    ServerOptions,
-} from 'vscode-languageclient/node';
+import { CancellationToken, MessageSignature } from 'vscode-jsonrpc';
+import { LanguageClient } from 'vscode-languageclient/node';
+import { LanguageClientOptions, ServerOptions } from 'vscode-languageclient';
 import CompositeDisposable from '../../compositeDisposable';
 import { IDisposable } from '../../disposable';
 import { languageServerOptions } from '../../shared/options';