Skip to content

Commit 5f0208d

Browse files
authored
Remove isOptional from IPackage
1 parent b4b22c1 commit 5f0208d

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

src/lsptoolshost/extensions/builtInComponents.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6+
import * as vscode from 'vscode';
67
import * as fs from 'fs';
78
import * as path from 'path';
89
import { LanguageServerOptions } from '../../shared/options';
@@ -49,7 +50,7 @@ export const componentInfo: { [key: string]: ComponentInfo } = {
4950
export function getComponentPaths(
5051
componentName: string,
5152
options: LanguageServerOptions | undefined,
52-
channel?: { warn: (message: string) => void }
53+
channel?: vscode.LogOutputChannel
5354
): string[] {
5455
const component = componentInfo[componentName];
5556
const baseFolder = getComponentFolderPath(component, options);

src/packageManager/IPackage.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,4 @@ export interface IPackage {
1313
platformId?: string;
1414
integrity?: string;
1515
isFramework?: boolean;
16-
isOptional?: boolean;
1716
}

src/packageManager/absolutePathPackage.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ export class AbsolutePathPackage implements IPackage {
2020
public fallbackUrl?: string,
2121
public platformId?: string,
2222
public integrity?: string,
23-
public isFramework?: boolean,
24-
public isOptional?: boolean
23+
public isFramework?: boolean
2524
) {}
2625

2726
public static getAbsolutePathPackage(pkg: Package, extensionPath: string) {
@@ -37,8 +36,7 @@ export class AbsolutePathPackage implements IPackage {
3736
pkg.fallbackUrl,
3837
pkg.platformId,
3938
pkg.integrity,
40-
pkg.isFramework,
41-
pkg.isOptional
39+
pkg.isFramework
4240
);
4341
}
4442
}

0 commit comments

Comments
 (0)