Skip to content

Commit 5f1bc05

Browse files
authored
Add comment
1 parent bdf508f commit 5f1bc05

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tasks/vsceTasks.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ export async function verifySignature(vsixPath: string) {
108108
if (spawnResult.code != 0) {
109109
throw new Error(`'${vsceArgs.join(' ')}' failed with code ${spawnResult.code}.`);
110110
} else if (spawnResult.stdout != 'Signature verification result: Success') {
111+
// This is a brittle check but the command does not return a non-zero exit code for failed validation.
112+
// Opened https://github.com/microsoft/vscode-vsce/issues/1192 to track this.
113+
111114
console.log(spawnResult.stdout);
112115
throw new Error(`Signature verification failed - '${vsceArgs.join(' ')}'.`);
113116
}

0 commit comments

Comments
 (0)