Skip to content

Commit 62b9fe2

Browse files
committed
Address review comments
1 parent 5c9ee8e commit 62b9fe2

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/features/commands.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@ export default function registerCommands(server: OmnisharpServer, extensionPath:
2727
// running the command activates the extension, which is all we need for installation to kickoff
2828
let d5 = vscode.commands.registerCommand('csharp.downloadDebugger', () => { });
2929

30-
return vscode.Disposable.from(d1, d2, d3, d4, d5,
31-
dotnetTest.registerDotNetTestRunCommand(server),
32-
dotnetTest.registerDotNetTestDebugCommand(server));
30+
// register two commands for running and debugging xunit tests
31+
let d6 = dotnetTest.registerDotNetTestRunCommand(server);
32+
let d7 = dotnetTest.registerDotNetTestDebugCommand(server);
33+
34+
return vscode.Disposable.from(d1, d2, d3, d4, d5, d6, d7);
3335
}
3436

3537
function pickProjectAndStart(server: OmnisharpServer) {

src/features/dotnetTest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export function runDotnetTest(testMethod: string, fileName: string, server: Omni
4949
}
5050
},
5151
reason => {
52-
vscode.window.showErrorMessage('Fail to run test because ' + reason + '.');
52+
vscode.window.showErrorMessage(`Failed to run test because ${reason}.`);
5353
});
5454
}
5555

@@ -68,7 +68,7 @@ export function debugDotnetTest(testMethod: string, fileName: string, server: Om
6868
}
6969
).then(
7070
response => { },
71-
reason => { vscode.window.showErrorMessage('Failed to start debugger on test because ' + reason + '.') });
71+
reason => { vscode.window.showErrorMessage(`Failed to start debugger on test because ${reason}.`) });
7272
});
7373
}
7474

0 commit comments

Comments
 (0)