Skip to content

Commit 6322c77

Browse files
authored
Merge pull request #6128 from dibarbet/use_node_18
Upgrade to node 18
2 parents 4fca126 + 25b623b commit 6322c77

File tree

6 files changed

+100
-34
lines changed

6 files changed

+100
-34
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
First install:
66

7-
* Node.js ([v16.16 LTS](https://nodejs.org/en/blog/release/v16.16.0) is recommended).
8-
* Npm (The version shipped with node is fine, for example for v16.16.0 it would be 8.19.2)
7+
* Node.js ([v18.17.0 LTS](https://nodejs.org/de/blog/release/v18.17.0) is recommended).
8+
* Npm (The version shipped with node is fine)
99
* .NET 7.0 SDK (dotnet should be on your path)
1010

1111
### Build and run the extension

azure-pipelines-official.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ stages:
2222
prereleaseFlag: $(prereleaseFlag)
2323
pool:
2424
name: NetCore1ESPool-Internal
25-
demands: ImageOverride -equals Build.Ubuntu.1804.Amd64
25+
demands: ImageOverride -equals Build.Ubuntu.2204.Amd64
2626

2727
# TODO: add compliance, signing.

azure-pipelines.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ stages:
2828
prereleaseFlag: $(prereleaseFlag)
2929
pool:
3030
name: NetCore-Public
31-
demands: ImageOverride -equals Build.Ubuntu.1804.Amd64.Open
31+
demands: ImageOverride -equals Build.Ubuntu.2204.Amd64.Open
3232

3333
- stage: Test
3434
displayName: Test
@@ -38,7 +38,7 @@ stages:
3838
strategy:
3939
matrix:
4040
linux:
41-
demandsName: ImageOverride -equals Build.Ubuntu.1804.Amd64.Open
41+
demandsName: ImageOverride -equals Build.Ubuntu.2204.Amd64.Open
4242
pool:
4343
name: NetCore-Public
4444
demands: $(demandsName)

azure-pipelines/prereqs.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ steps:
44
- task: NuGetAuthenticate@1
55

66
- task: NodeTool@0
7-
displayName: 'Install Node.js 16.x'
7+
displayName: 'Install Node.js 18.x'
88
inputs:
9-
versionSpec: '16.x'
9+
versionSpec: '18.x'
1010

1111
- task: UseDotNet@2
1212
displayName: 'Install .NET Core SDKs'
1313
inputs:
14-
version: '7.0.100'
14+
version: '7.x'
1515

1616
# Set the CI build number to the VSIX version we're creating from this build.
1717
- script: |

package-lock.json

Lines changed: 91 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
"@types/yauzl": "2.10.0",
129129
"@typescript-eslint/eslint-plugin": "^5.61.0",
130130
"@typescript-eslint/parser": "^5.61.0",
131-
"@vscode/test-electron": "2.1.3",
131+
"@vscode/test-electron": "2.3.4",
132132
"archiver": "5.3.0",
133133
"chai": "4.3.4",
134134
"chai-arrays": "2.2.0",

0 commit comments

Comments
 (0)