Localize message box messages and titles

Author: JoeRobich

l10n/bundle.l10n.json

@@ -1,4 +1,7 @@
 {
+  "How to setup Remote Debugging": "How to setup Remote Debugging",
+  "The C# extension for Visual Studio Code is incompatible on {0} {1} with the VS Code Remote Extensions. To see avaliable workarounds, click on '{2}'.": "The C# extension for Visual Studio Code is incompatible on {0} {1} with the VS Code Remote Extensions. To see avaliable workarounds, click on '{2}'.",
+  "The C# extension for Visual Studio Code is incompatible on {0} {1}.": "The C# extension for Visual Studio Code is incompatible on {0} {1}.",
   "Cannot create .NET debug configurations. No workspace folder was selected.": "Cannot create .NET debug configurations. No workspace folder was selected.",
   "Cannot create .NET debug configurations. The server is still initializing or has exited unexpectedly.": "Cannot create .NET debug configurations. The server is still initializing or has exited unexpectedly.",
   "Cannot create .NET debug configurations. The active C# project is not within folder '{0}'.": "Cannot create .NET debug configurations. The active C# project is not within folder '{0}'.",
@@ -125,20 +128,32 @@
   "View Debug Docs": "View Debug Docs",
   "Ignore": "Ignore",
   "Run and Debug: A valid browser is not installed. Please install Edge or Chrome.": "Run and Debug: A valid browser is not installed. Please install Edge or Chrome.",
+  "OmniSharp requires a complete install of Mono (including MSBuild) to provide language services when `omnisharp.useModernNet` is disabled in Settings. Please install the latest Mono and restart.": "OmniSharp requires a complete install of Mono (including MSBuild) to provide language services when `omnisharp.useModernNet` is disabled in Settings. Please install the latest Mono and restart.",
+  "Download Mono": "Download Mono",
+  "Open settings": "Open settings",
   "dotnet.server.useOmnisharp option has changed. Please reload the window to apply the change": "dotnet.server.useOmnisharp option has changed. Please reload the window to apply the change",
   "Reload Window": "Reload Window",
   "C# configuration has changed. Would you like to relaunch the Language Server with your changes?": "C# configuration has changed. Would you like to relaunch the Language Server with your changes?",
   "Restart Language Server": "Restart Language Server",
+  "project.json is no longer a supported project format for .NET Core applications.": "project.json is no longer a supported project format for .NET Core applications.",
+  "More Detail": "More Detail",
+  "Some projects have trouble loading. Please review the output for more details.": "Some projects have trouble loading. Please review the output for more details.",
+  "There are unresolved dependencies. Please execute the restore command to continue.": "There are unresolved dependencies. Please execute the restore command to continue.",
+  "Restore": "Restore",
+  "Package {0} download from {1} failed integrity check. Some features may not work as expected. Please restart Visual Studio Code to retrigger the download": "Package {0} download from {1} failed integrity check. Some features may not work as expected. Please restart Visual Studio Code to retrigger the download",
+  "Failed to run test: {0}": "Failed to run test: {0}",
+  "Failed to start debugger: {0}": "Failed to start debugger: {0}",
+  "Test run already in progress": "Test run already in progress",
   "Your workspace has multiple Visual Studio Solution files; please select one to get full IntelliSense.": "Your workspace has multiple Visual Studio Solution files; please select one to get full IntelliSense.",
   "Choose": "Choose",
   "Choose and set default": "Choose and set default",
   "Do not load any": "Do not load any",
+  "Detected change in telemetry settings. These will not take effect until the language server is restarted, would you like to restart?": "Detected change in telemetry settings. These will not take effect until the language server is restarted, would you like to restart?",
   "IntelliCode features will not be available, {0} failed to activate.": "IntelliCode features will not be available, {0} failed to activate.",
   "Go to output": "Go to output",
   "Suppress notification": "Suppress notification",
   "Restore {0}": "Restore {0}",
   "Restore already in progress": "Restore already in progress",
-  "Restore": "Restore",
   "Sending request": "Sending request",
   "C# configuration has changed. Would you like to reload the window to apply your changes?": "C# configuration has changed. Would you like to reload the window to apply your changes?",
   "Nested Code Action": "Nested Code Action",
@@ -154,6 +169,9 @@
   "Transport attach could not obtain processes list.": "Transport attach could not obtain processes list.",
   "Error Message: ": "Error Message: ",
   "See {0} output": "See {0} output",
+  "Text editor must be focused to fix all issues": "Text editor must be focused to fix all issues",
+  "Fix all issues": "Fix all issues",
+  "Select fix all action": "Select fix all action",
   "Failed to set extension directory": "Failed to set extension directory",
   "Failed to set debugadpter directory": "Failed to set debugadpter directory",
   "Failed to set install complete file path": "Failed to set install complete file path",

src/features/fixAllProvider.ts

@@ -63,29 +63,30 @@ export class OmniSharpFixAllProvider extends AbstractProvider implements vscode.
     private async fixAllMenu(server: OmniSharpServer, scope: protocol.FixAllScope): Promise<void> {
         const fileName = vscode.window.activeTextEditor?.document.fileName;
         if (fileName === undefined) {
-            vscode.window.showWarningMessage('Text editor must be focused to fix all issues');
+            vscode.window.showWarningMessage(vscode.l10n.t('Text editor must be focused to fix all issues'));
             return;
         }
 
         const availableFixes = await serverUtils.getFixAll(server, { FileName: fileName, Scope: scope });
 
         let targets = availableFixes.Items.map((x) => `${x.Id}: ${x.Message}`);
 
+        const fixAllItem = vscode.l10n.t('Fix all issues');
         if (scope === protocol.FixAllScope.Document) {
-            targets = ['Fix all issues', ...targets];
+            targets = [fixAllItem, ...targets];
         }
 
         const action = await vscode.window.showQuickPick(targets, {
             matchOnDescription: true,
-            placeHolder: `Select fix all action`,
+            placeHolder: vscode.l10n.t(`Select fix all action`),
         });
 
         if (action === undefined) {
             return;
         }
 
         let filter: FixAllItem[] | undefined;
-        if (action !== 'Fix all issues') {
+        if (action !== fixAllItem) {
             const actionTokens = action.split(':');
             filter = [{ Id: actionTokens[0], Message: actionTokens[1] }];
         }

src/lsptoolshost/roslynLanguageServer.ts

@@ -813,10 +813,11 @@ export class RoslynLanguageServer {
         // Subscribe to telemetry events so we can enable/disable as needed
         this._languageClient.addDisposable(
             vscode.env.onDidChangeTelemetryEnabled((_: boolean) => {
-                const title = 'Restart Language Server';
+                const title = vscode.l10n.t('Restart Language Server');
                 const command = 'dotnet.restartServer';
-                const message =
-                    'Detected change in telemetry settings. These will not take effect until the language server is restarted, would you like to restart?';
+                const message = vscode.l10n.t(
+                    'Detected change in telemetry settings. These will not take effect until the language server is restarted, would you like to restart?'
+                );
                 ShowInformationMessage(vscode, message, { title, command });
             })
         );

src/lsptoolshost/unitTesting.ts

@@ -68,7 +68,7 @@ async function runTests(
     dotnetTestChannel: vscode.OutputChannel
 ): Promise<TestProgress | undefined> {
     if (_testRunInProgress) {
-        vscode.window.showErrorMessage('Test run already in progress');
+        vscode.window.showErrorMessage(vscode.l10n.t('Test run already in progress'));
         return;
     }
 

src/main.ts

@@ -285,12 +285,15 @@ export async function activate(
     }
 
     if (!isSupportedPlatform(platformInfo)) {
-        let errorMessage = `The C# extension for Visual Studio Code is incompatible on ${platformInfo.platform} ${platformInfo.architecture}`;
-
         // Check to see if VS Code is running remotely
         if (context.extension.extensionKind === vscode.ExtensionKind.Workspace) {
-            const setupButton = 'How to setup Remote Debugging';
-            errorMessage += ` with the VS Code Remote Extensions. To see avaliable workarounds, click on '${setupButton}'.`;
+            const setupButton = vscode.l10n.t('How to setup Remote Debugging');
+            const errorMessage = vscode.l10n.t(
+                `The C# extension for Visual Studio Code is incompatible on {0} {1} with the VS Code Remote Extensions. To see avaliable workarounds, click on '{2}'.`,
+                platformInfo.platform,
+                platformInfo.architecture,
+                setupButton
+            );
 
             await vscode.window.showErrorMessage(errorMessage, setupButton).then((selectedItem) => {
                 if (selectedItem === setupButton) {
@@ -300,6 +303,11 @@ export async function activate(
                 }
             });
         } else {
+            const errorMessage = vscode.l10n.t(
+                'The C# extension for Visual Studio Code is incompatible on {0} {1}.',
+                platformInfo.platform,
+                platformInfo.architecture
+            );
             await vscode.window.showErrorMessage(errorMessage);
         }
 

src/observers/errorMessageObserver.ts

@@ -13,6 +13,7 @@ import {
 import { vscode } from '../vscodeAdapter';
 import showErrorMessage from './utils/showErrorMessage';
 import { EventType } from '../omnisharp/eventType';
+import { l10n } from 'vscode';
 
 export class ErrorMessageObserver {
     constructor(private vscode: vscode) {}
@@ -37,7 +38,11 @@ export class ErrorMessageObserver {
         if (!event.retry) {
             showErrorMessage(
                 this.vscode,
-                `Package ${event.packageDescription} download from ${event.url} failed integrity check. Some features may not work as expected. Please restart Visual Studio Code to retrigger the download`
+                l10n.t(
+                    `Package {0} download from {1} failed integrity check. Some features may not work as expected. Please restart Visual Studio Code to retrigger the download`,
+                    event.packageDescription,
+                    event.url
+                )
             );
         }
     }
@@ -47,10 +52,10 @@ export class ErrorMessageObserver {
     }
 
     private handleDotnetTestRunFailure(event: DotNetTestRunFailure) {
-        showErrorMessage(this.vscode, `Failed to run test because ${event.message}.`);
+        showErrorMessage(this.vscode, l10n.t(`Failed to run test: {0}`, event.message));
     }
 
     private handleDotNetTestDebugStartFailure(event: DotNetTestDebugStartFailure) {
-        showErrorMessage(this.vscode, `Failed to start debugger: ${event.message}`);
+        showErrorMessage(this.vscode, l10n.t(`Failed to start debugger: {0}`, event.message));
     }
 }

src/observers/informationMessageObserver.ts

@@ -8,6 +8,7 @@ import { vscode } from '../vscodeAdapter';
 import showInformationMessage from '../shared/observers/utils/showInformationMessage';
 import { EventType } from '../omnisharp/eventType';
 import { omnisharpOptions } from '../shared/options';
+import { l10n } from 'vscode';
 
 export class InformationMessageObserver {
     constructor(private vscode: vscode) {}
@@ -23,8 +24,13 @@ export class InformationMessageObserver {
     private async handleOmnisharpServerUnresolvedDependencies() {
         //to do: determine if we need the unresolved dependencies message
         if (!omnisharpOptions.suppressDotnetRestoreNotification) {
-            const message = `There are unresolved dependencies. Please execute the restore command to continue.`;
-            return showInformationMessage(this.vscode, message, { title: 'Restore', command: 'dotnet.restore.all' });
+            const message = l10n.t(
+                `There are unresolved dependencies. Please execute the restore command to continue.`
+            );
+            return showInformationMessage(this.vscode, message, {
+                title: l10n.t('Restore'),
+                command: 'dotnet.restore.all',
+            });
         }
     }
 }

src/observers/warningMessageObserver.ts

@@ -10,15 +10,16 @@ import { Scheduler, Subject } from 'rxjs';
 
 import showWarningMessage from './utils/showWarningMessage';
 import { EventType } from '../omnisharp/eventType';
+import { l10n } from 'vscode';
 
 export class WarningMessageObserver {
     private warningMessageDebouncer: Subject<BaseEvent>;
 
     constructor(private vscode: vscode, private disableMsBuildDiagnosticWarning: () => boolean, scheduler?: Scheduler) {
         this.warningMessageDebouncer = new Subject<BaseEvent>();
         this.warningMessageDebouncer.pipe(debounceTime(1500, scheduler)).subscribe(async (_) => {
-            const message = 'Some projects have trouble loading. Please review the output for more details.';
-            await showWarningMessage(this.vscode, message, { title: 'Show Output', command: 'o.showOutput' });
+            const message = l10n.t('Some projects have trouble loading. Please review the output for more details.');
+            await showWarningMessage(this.vscode, message, { title: l10n.t('Show Output'), command: 'o.showOutput' });
         });
     }
 

src/omnisharp/extension.ts

@@ -108,9 +108,10 @@ export async function activate(
             server.onServerStart(() => {
                 utils.requestWorkspaceInformation(server).then((workspaceInfo) => {
                     if (workspaceInfo.DotNet && workspaceInfo.DotNet.Projects.length > 0) {
-                        const shortMessage =
-                            'project.json is no longer a supported project format for .NET Core applications.';
-                        const moreDetailItem: vscode.MessageItem = { title: 'More Detail' };
+                        const shortMessage = vscode.l10n.t(
+                            'project.json is no longer a supported project format for .NET Core applications.'
+                        );
+                        const moreDetailItem: vscode.MessageItem = { title: vscode.l10n.t('More Detail') };
                         vscode.window.showWarningMessage(shortMessage, moreDetailItem).then((_) => {
                             eventStream.post(new ProjectJsonDeprecatedWarning());
                         });

src/omnisharp/requirementCheck.ts

@@ -116,13 +116,18 @@ async function promptToDownloadDotNetSDK() {
 
 async function promptToDownloadMono() {
     return new Promise<PromptResult>((resolve, _) => {
-        const message =
-            'OmniSharp requires a complete install of Mono (including MSBuild) to provide language services when `omnisharp.useModernNet` is disabled in Settings. Please install the latest Mono and restart.';
+        const message = vscode.l10n.t(
+            'OmniSharp requires a complete install of Mono (including MSBuild) to provide language services when `omnisharp.useModernNet` is disabled in Settings. Please install the latest Mono and restart.'
+        );
 
         const messageOptions: vscode.MessageOptions = { modal: true };
 
-        const yesItem: PromptItem = { title: 'Download Mono', result: PromptResult.Yes };
-        const noItem: PromptItem = { title: 'Open settings', result: PromptResult.No, isCloseAffordance: true };
+        const yesItem: PromptItem = { title: vscode.l10n.t('Download Mono'), result: PromptResult.Yes };
+        const noItem: PromptItem = {
+            title: vscode.l10n.t('Open settings'),
+            result: PromptResult.No,
+            isCloseAffordance: true,
+        };
 
         vscode.window
             .showErrorMessage(message, messageOptions, noItem, yesItem)