Merge pull request #969 from DustinCampbell/v1.5.3

Cherry pick strictSSL fix and create 1.5.3

Author: DustinCampbell

README.md

@@ -18,6 +18,10 @@ The C# extension is powered by [OmniSharp](https://github.com/OmniSharp/omnishar
 * [Documentation](https://code.visualstudio.com/docs/languages/csharp)
 * [Video Tutorial compiling with .NET Core](https://channel9.msdn.com/Blogs/dotnet/Get-started-with-VS-Code-using-CSharp-and-NET-Core)
 
+### What's New in 1.5.3
+
+* Use value of `http.proxyStrictSSL` even when `http.proxy` is not set. ([#957](https://github.com/OmniSharp/omnisharp-vscode/issues/957))
+
 ### What's New in 1.5.2
 
 * Ensure diagnostics are cleared in files when they are no longer needed. ([#858](https://github.com/OmniSharp/omnisharp-vscode/issues/858))

package.json

@@ -1,7 +1,7 @@
 {
   "name": "csharp",
   "publisher": "ms-vscode",
-  "version": "1.5.2",
+  "version": "1.5.3",
   "description": "C# for Visual Studio Code (powered by OmniSharp).",
   "displayName": "C#",
   "author": "Microsoft Corporation",

src/common.ts

@@ -25,6 +25,10 @@ export function getBinPath() {
     return path.resolve(getExtensionPath(), "bin");
 }
 
+export function isBoolean(obj: any): obj is boolean {
+    return obj === true || obj === false;
+}
+
 export function buildPromiseChain<T, TResult>(array: T[], builder: (item: T) => Promise<TResult>): Promise<TResult> {
     return array.reduce(
         (promise, n) => promise.then(() => builder(n)),

src/packages.ts

@@ -173,7 +173,8 @@ function downloadFile(urlString: string, pkg: Package, logger: Logger, status: S
     const options: https.RequestOptions = {
         host: url.host,
         path: url.path,
-        agent: getProxyAgent(url, proxy, strictSSL)
+        agent: getProxyAgent(url, proxy, strictSSL),
+        rejectUnauthorized: util.isBoolean(strictSSL) ? strictSSL : true
     };
 
     return new Promise<void>((resolve, reject) => {

src/proxy.ts

@@ -6,6 +6,7 @@
 'use strict';
 
 import { Url, parse as parseUrl } from 'url';
+import { isBoolean } from './common';
 import HttpProxyAgent = require('http-proxy-agent');
 import HttpsProxyAgent = require('https-proxy-agent');
 
@@ -32,15 +33,11 @@ export function getProxyAgent(requestURL: Url, proxy: string, strictSSL: boolean
         return null;
     }
 
-    if (strictSSL === undefined) {
-        strictSSL = true;
-    }
-
     const opts = {
         host: proxyEndpoint.hostname,
         port: Number(proxyEndpoint.port),
         auth: proxyEndpoint.auth,
-        rejectUnauthorized: strictSSL
+        rejectUnauthorized: isBoolean(strictSSL) ? strictSSL : true
     };
 
     return requestURL.protocol === 'http:' ? new HttpProxyAgent(opts) : new HttpsProxyAgent(opts);