Merge pull request #3470 from 928PJY/statusBar

Reset and hide StatusBar after all dependencies installed

Author: JoeRobich

src/observers/OmnisharpStatusBarObserver.ts

@@ -42,6 +42,9 @@ export class OmnisharpStatusBarObserver extends BaseStatusBarItemObserver {
             case EventType.InstallationStart:
                 this.SetAndShowStatusBar("$(desktop-download) Installing packages...", '', '', `Installing package '${(<InstallationStart>event).packageDescription}'`);
                 break;
+            case EventType.InstallationSuccess:
+                this.ResetAndHideStatusBar();
+                break;
             case EventType.DownloadProgress:
                 let progressEvent = <DownloadProgress>event;
                 this.SetAndShowStatusBar("$(cloud-download) Downloading packages", '', '', `Downloading package '${progressEvent.packageDescription}'... ${progressEvent.downloadPercentage}%`);

test/unitTests/logging/OmnisharpStatusBarObserver.test.ts

@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { StatusBarItem } from '../../../src/vscodeAdapter';
-import { OmnisharpOnBeforeServerInstall, OmnisharpOnBeforeServerStart, OmnisharpServerOnServerError, OmnisharpServerOnStart, OmnisharpServerOnStop, DownloadStart, InstallationStart, DownloadProgress, OmnisharpServerOnStdErr, BaseEvent } from '../../../src/omnisharp/loggingEvents';
+import { OmnisharpOnBeforeServerInstall, OmnisharpOnBeforeServerStart, OmnisharpServerOnServerError, OmnisharpServerOnStart, OmnisharpServerOnStop, DownloadStart, InstallationStart, DownloadProgress, OmnisharpServerOnStdErr, BaseEvent, InstallationSuccess } from '../../../src/omnisharp/loggingEvents';
 import { expect, should } from 'chai';
 import { OmnisharpStatusBarObserver, StatusBarColors } from '../../../src/observers/OmnisharpStatusBarObserver';
 
@@ -110,4 +110,17 @@ suite('OmnisharpStatusBarObserver', () => {
         expect(statusBarItem.tooltip).to.contain(event.packageDescription);
         expect(statusBarItem.tooltip).to.contain(event.downloadPercentage);
     });
+
+    test('InstallationSuccess: Status bar is hidden and the attributes are set to undefined', () => {
+        let installationEvent = new InstallationStart("somePackage");
+        observer.post(installationEvent);
+
+        let successEvent = new InstallationSuccess();
+        observer.post(successEvent);
+
+        expect(hideCalled).to.be.true;
+        expect(statusBarItem.text).to.be.undefined;
+        expect(statusBarItem.command).to.be.undefined;
+        expect(statusBarItem.color).to.be.undefined;
+    });
 });