Skip to content

Commit 6a3c9fb

Browse files
committed
clean up the tmp file usage
1 parent a5e35ca commit 6a3c9fb

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

src/packageManager/FileDownloader.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ async function downloadFile(description: string, urlString: string, eventStream:
7373
let packageSize = parseInt(response.headers['content-length'], 10);
7474
let downloadedBytes = 0;
7575
let downloadPercentage = 0;
76-
//let tmpFile = fs.createWriteStream(null, { fd });
7776

7877
eventStream.post(new DownloadSizeObtained(packageSize));
7978

src/packageManager/PackageManager.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,14 @@ import { InstallZip } from './ZipInstaller';
1212
import { EventStream } from '../EventStream';
1313
import { NetworkSettingsProvider } from "../NetworkSettings";
1414
import { filterPackages } from "./PackageFilterer";
15-
import { CreateTmpFile, TmpAsset } from "../CreateTmpAsset";
1615

1716
// Package manager needs a list of packages to be filtered based on platformInfo then download and install them
1817
// Note that the packages that this component will install needs absolute paths for the installPath, intsallTestPath and the binaries
1918
export async function DownloadAndInstallPackages(packages: Package[], provider: NetworkSettingsProvider, platformInfo: PlatformInformation, eventStream: EventStream) {
2019
let filteredPackages = await filterPackages(packages, platformInfo);
2120
if (filteredPackages) {
22-
let tmpFile: TmpAsset;
2321
for (let pkg of filteredPackages) {
2422
try {
25-
tmpFile = await CreateTmpFile();
2623
let buffer = await DownloadFile(pkg.description, eventStream, provider, pkg.url, pkg.fallbackUrl);
2724
await InstallZip(buffer, pkg.description, pkg.installPath, pkg.binaries, eventStream);
2825
}
@@ -34,12 +31,6 @@ export async function DownloadAndInstallPackages(packages: Package[], provider:
3431
throw error;
3532
}
3633
}
37-
finally {
38-
//clean the temporary file
39-
if (tmpFile) {
40-
tmpFile.dispose();
41-
}
42-
}
4334
}
4435
}
4536
}

0 commit comments

Comments
 (0)