Another null vs undefined fix

Author: winstliu

test/unitTests/options.test.ts

@@ -40,33 +40,33 @@ suite("Options tests", () => {
 
     test('Verify return no excluded paths when files.exclude empty', () => {
         const vscode = getVSCodeWithConfig();
-        updateConfig(vscode, null, 'files.exclude', {});
+        updateConfig(vscode, undefined, 'files.exclude', {});
 
         const excludedPaths = Options.getExcludedPaths(vscode);
         expect(excludedPaths).to.be.empty;
     });
 
     test('Verify return excluded paths when files.exclude populated', () => {
         const vscode = getVSCodeWithConfig();
-        updateConfig(vscode, null, 'files.exclude', { "**/node_modules": true, "**/assets": false });
+        updateConfig(vscode, undefined, 'files.exclude', { "**/node_modules": true, "**/assets": false });
 
         const excludedPaths = Options.getExcludedPaths(vscode);
         expect(excludedPaths).to.equalTo(["**/node_modules"]);
     });
 
     test('Verify return no excluded paths when files.exclude and search.exclude empty', () => {
         const vscode = getVSCodeWithConfig();
-        updateConfig(vscode, null, 'files.exclude', {});
-        updateConfig(vscode, null, 'search.exclude', {});
+        updateConfig(vscode, undefined, 'files.exclude', {});
+        updateConfig(vscode, undefined, 'search.exclude', {});
 
         const excludedPaths = Options.getExcludedPaths(vscode, true);
         expect(excludedPaths).to.be.empty;
     });
 
     test('Verify return excluded paths when files.exclude and search.exclude populated', () => {
         const vscode = getVSCodeWithConfig();
-        updateConfig(vscode, null, 'files.exclude', { "/Library": true });
-        updateConfig(vscode, null, 'search.exclude', { "**/node_modules": true, "**/assets": false });
+        updateConfig(vscode, undefined, 'files.exclude', { "/Library": true });
+        updateConfig(vscode, undefined, 'search.exclude', { "**/node_modules": true, "**/assets": false });
 
         const excludedPaths = Options.getExcludedPaths(vscode, true);
         expect(excludedPaths).to.be.equalTo(["/Library", "**/node_modules"]);

test/unitTests/testAssets/Fakes.ts

@@ -187,7 +187,7 @@ export function getVSCodeWithConfig() {
     const _csharpConfig = getWorkspaceConfiguration();
     const _razorConfig = getWorkspaceConfiguration();
 
-    vscode.workspace.getConfiguration = (section?, resource?) => {
+    vscode.workspace.getConfiguration = (section, resource) => {
         if (section === undefined) {
             return _vscodeConfig;
         } else if (section === 'omnisharp') {
@@ -204,7 +204,7 @@ export function getVSCodeWithConfig() {
     return vscode;
 }
 
-export function updateConfig(vscode: vscode.vscode, section: string, config: string, value: any) {
-    let workspaceConfig = vscode.workspace.getConfiguration(section);
+export function updateConfig(vscode: vscode.vscode, section: string | undefined, config: string, value: any) {
+    const workspaceConfig = vscode.workspace.getConfiguration(section);
     workspaceConfig.update(config, value);
 }