Rename to value

Author: akshita31

src/packageManager/AbsolutePath.ts

@@ -6,8 +6,8 @@
 import { isAbsolute, resolve } from "path";
 
 export class AbsolutePath{
-    constructor(public path: string) {
-        if (!isAbsolute(path)) {
+    constructor(public value: string) {
+        if (!isAbsolute(value)) {
             throw new Error("The path must be absolute");
         }
     }

src/packageManager/InstallablePackage.ts

@@ -42,7 +42,7 @@ function getAbsoluteInstallTestPath(pkg: Package, extensionPath: string): Absolu
 } 
 
 function getAbsoluteBinaries(pkg: Package, extensionPath: string): AbsolutePath[] { 
-    let basePath = getAbsoluteInstallPath(pkg, extensionPath).path;
+    let basePath = getAbsoluteInstallPath(pkg, extensionPath).value;
     if (pkg.binaries) { 
         return pkg.binaries.map(value => AbsolutePath.getAbsolutePath(basePath, value)); 
     } 

src/packageManager/PackageFilterer.ts

@@ -43,6 +43,6 @@ async function filterAlreadyInstalledPackages(packages: InstallablePackage[]): P
             return true;
         }
 
-        return !(await util.fileExists(testPath.path));
+        return !(await util.fileExists(testPath.value));
       });
 }

src/packageManager/ZipInstaller.ts

@@ -26,7 +26,7 @@ export async function InstallZip(buffer: Buffer, description: string, destinatio
             zipFile.readEntry();
 
             zipFile.on('entry', (entry: yauzl.Entry) => {
-                let absoluteEntryPath = path.resolve(destinationInstallPath.path, entry.fileName);
+                let absoluteEntryPath = path.resolve(destinationInstallPath.value, entry.fileName);
 
                 if (entry.fileName.endsWith('/')) {
                     // Directory - create it
@@ -50,7 +50,7 @@ export async function InstallZip(buffer: Buffer, description: string, destinatio
                                 return reject(new NestedError('Error creating directory for zip file entry', err));
                             }
 
-                            let binaryPaths = binaries && binaries.map(binary => binary.path);
+                            let binaryPaths = binaries && binaries.map(binary => binary.value);
 
                             // Make sure executable files have correct permissions when extracted
                             let fileMode = binaryPaths && binaryPaths.indexOf(absoluteEntryPath) !== -1

test/unitTests/Packages/ZipInstaller.test.ts

@@ -50,7 +50,7 @@ suite('ZipInstaller', () => {
     test('The folder is unzipped and all the files are present at the expected paths', async () => {
         await InstallZip(testZip.buffer, fileDescription, installationPath, [], eventStream);
         for (let elem of testZip.files) {
-            let filePath = path.join(installationPath.path, elem.path);
+            let filePath = path.join(installationPath.value, elem.path);
             expect(await util.fileExists(filePath)).to.be.true;
         }
     });
@@ -65,11 +65,11 @@ suite('ZipInstaller', () => {
 
     test('The folder is unzipped and the binaries have the expected permissions(except on Windows)', async () => {
         if (!((await PlatformInformation.GetCurrent()).isWindows())) {
-            let absoluteBinaries = binaries.map(binary => AbsolutePath.getAbsolutePath(installationPath.path, binary.path));
+            let absoluteBinaries = binaries.map(binary => AbsolutePath.getAbsolutePath(installationPath.value, binary.path));
             await InstallZip(testZip.buffer, fileDescription, installationPath, absoluteBinaries, eventStream);
             for (let binaryPath of absoluteBinaries) {
-                expect(await util.fileExists(binaryPath.path)).to.be.true;
-                let mode = (await fs.stat(binaryPath.path)).mode;
+                expect(await util.fileExists(binaryPath.value)).to.be.true;
+                let mode = (await fs.stat(binaryPath.value)).mode;
                 expect(mode & 0o7777).to.be.equal(0o755, `Expected mode for path ${binaryPath}`);
             }
         }