Address feedback

Author: mavasani

src/features/diagnosticsProvider.ts

@@ -135,14 +135,16 @@ class OmniSharpDiagnosticsProvider extends AbstractSupport {
     ) {
         super(server, languageMiddlewareFeature);
 
+        const analyzersEnabledLegacyOption = vscode.workspace.getConfiguration('omnisharp').get('enableRoslynAnalyzers', false);
         const useOmnisharpServer = vscode.workspace.getConfiguration('dotnet').get('server.useOmnisharp', false);
-        this._analyzersEnabled =
+        const analyzersEnabledNewOption =
             vscode.workspace
                 .getConfiguration('dotnet')
                 .get<string>(
                     'backgroundAnalysis.analyzerDiagnosticsScope',
                     useOmnisharpServer ? 'none' : 'openFiles'
                 ) != 'none';
+        this._analyzersEnabled = analyzersEnabledLegacyOption || analyzersEnabledNewOption;
         this._validationAdvisor = validationAdvisor;
         this._diagnostics = vscode.languages.createDiagnosticCollection('csharp');
         this._suppressHiddenDiagnostics = vscode.workspace

src/shared/options.ts

@@ -119,12 +119,14 @@ export class Options {
             'omnisharp.useEditorFormattingSettings',
             true
         );
+        const enableRoslynAnalyzersLegacyOption = Options.readOption<boolean>(config, 'omnisharp.enableRoslynAnalyzers', false);
         const diagnosticAnalysisScope = Options.readOption<string>(
             config,
             'dotnet.backgroundAnalysis.analyzerDiagnosticsScope',
             useOmnisharpServer ? 'none' : 'openFiles'
         );
-        const enableRoslynAnalyzers = diagnosticAnalysisScope != 'none';
+        const enableRoslynAnalyzersNewOption = diagnosticAnalysisScope != 'none';
+        const enableRoslynAnalyzers = enableRoslynAnalyzersLegacyOption || enableRoslynAnalyzersNewOption;
         const enableEditorConfigSupport = Options.readOption<boolean>(
             config,
             'omnisharp.enableEditorConfigSupport',
@@ -143,7 +145,13 @@ export class Options {
             'omnisharp.enableImportCompletion'
         );
         const enableAsyncCompletion = Options.readOption<boolean>(config, 'omnisharp.enableAsyncCompletion', false);
-        const analyzeOpenDocumentsOnly = diagnosticAnalysisScope == 'openFiles';
+        const analyzeOpenDocumentsOnlyLegacyOption = Options.readOption<boolean>(
+            config,
+            'omnisharp.analyzeOpenDocumentsOnly',
+            false
+        );
+        const analyzeOpenDocumentsOnlyNewOption = diagnosticAnalysisScope == 'openFiles';
+        const analyzeOpenDocumentsOnly = analyzeOpenDocumentsOnlyLegacyOption || analyzeOpenDocumentsOnlyNewOption;
         const organizeImportsOnFormat = Options.readOption<boolean>(config, 'omnisharp.organizeImportsOnFormat', false);
         const disableMSBuildDiagnosticWarning = Options.readOption<boolean>(
             config,