Skip to content

Commit 7157bbc

Browse files
Produce platform target to platform-specific .vsix's (#4850)
This PR is hopefully the penultimate step before the C# extension can switch to pushing platform specific .vsix's to the gallery. With this PR we are adding the `--target` argument when calling vsce.
1 parent 9e5ad03 commit 7157bbc

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@
117117
"tslint-no-unused-expression-chai": "0.1.4",
118118
"typescript": "4.2.4",
119119
"unzipper": "0.10.11",
120-
"vsce": "1.57.0",
120+
"vsce": "1.100.2",
121121
"vscode-test": "1.5.2",
122122
"webpack": "5.34.0",
123123
"webpack-cli": "4.6.0"
@@ -398,7 +398,7 @@
398398
}
399399
],
400400
"engines": {
401-
"vscode": "^1.58.0"
401+
"vscode": "^1.61.0"
402402
},
403403
"activationEvents": [
404404
"onDebugInitialConfigurations",

tasks/offlinePackagingTasks.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,11 @@ async function createPackageAsync(packageName: string, outputFolder: string, vsc
131131
else {
132132
vsceArgs.push(packageName);
133133
}
134+
135+
if (vscodePlatformId !== undefined) {
136+
vsceArgs.push("--target");
137+
vsceArgs.push(vscodePlatformId);
138+
}
134139
}
135140

136141
const spawnResult = await spawnNode(vsceArgs);

tasks/projectPaths.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export const offlineVscodeignorePath = path.join(rootPath, 'offline.vscodeignore
1313
export const onlineVscodeignorePath = path.join(rootPath, 'release.vscodeignore');
1414

1515
export const nodeModulesPath = path.join(rootPath, 'node_modules');
16-
export const vscePath = path.join(nodeModulesPath, 'vsce', 'out', 'vsce');
16+
export const vscePath = path.join(nodeModulesPath, 'vsce', 'vsce');
1717
export const mochaPath = path.join(nodeModulesPath, 'mocha', 'bin', 'mocha');
1818

1919
export const packageJsonPath = path.join(rootPath, "package.json");

0 commit comments

Comments
 (0)