Skip to content

Commit 737324e

Browse files
authored
Merge pull request #4389 from JoeRobich/fix-codecov-report
Fix code coverage reporting in PR CI.
2 parents f7544cb + c33ae53 commit 737324e

File tree

4 files changed

+59
-31
lines changed

4 files changed

+59
-31
lines changed

.github/workflows/ci.yml

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,22 +28,33 @@ jobs:
2828
node-version: '12.x'
2929

3030
- name: Install dependencies
31-
run: npm ci && npm i -g gulp
31+
run: |
32+
npm ci
33+
npm i -g gulp
3234
33-
- name: Build
35+
- name: Build extension package
3436
run: gulp 'vsix:release:package'
3537

36-
- name: Initialize code coverage
37-
run: gulp cov:instrument
38-
3938
- name: Run unit and integration tests
40-
run: gulp test
39+
run: |
40+
gulp cov:instrument
41+
gulp test
42+
gulp cov:merge
43+
npm run test:artifacts
4144
env:
4245
CODE_VERSION: 1.45.0
4346
DISPLAY: :99.0
4447

45-
- name: Report code coverage
46-
run: gulp cov:report
48+
- name: Report unit test coverage
49+
uses: codecov/codecov-action@v1
50+
with:
51+
token: ${{ secrets.CODECOV_TOKEN }}
52+
files: ./coverage/unit/lcov.info
53+
flags: unit
4754

48-
- name: Run artifact tests
49-
run: npm run test:artifacts
55+
- name: Report integration test coverage
56+
uses: codecov/codecov-action@v1
57+
with:
58+
token: ${{ secrets.CODECOV_TOKEN }}
59+
files: ./coverage/integration/lcov.info
60+
flags: integration

.github/workflows/release-ci.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ jobs:
1717
node-version: '12.x'
1818

1919
- name: Install dependencies
20-
run: npm ci && npm i -g gulp
20+
run: |
21+
npm ci
22+
npm i -g gulp
2123
22-
- name: Build
24+
- name: Build extension package
2325
run: gulp 'vsix:release:package'
2426

2527
- name: Run release tests
@@ -37,4 +39,4 @@ jobs:
3739
upload_url: ${{ github.event.release.upload_url }}
3840
asset_path: ./csharp-${{ env.VERSION }}.vsix
3941
asset_name: csharp-${{ env.VERSION }}.vsix
40-
asset_content_type: application/zip
42+
asset_content_type: application/zip

package-lock.json

Lines changed: 30 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,7 @@
5858
"gulp": "gulp"
5959
},
6060
"nyc": {
61-
"include": [
62-
"src/**/*.ts",
63-
"src/**/*.tsx"
64-
],
65-
"extension": [
66-
".ts",
67-
".tsx"
68-
],
69-
"require": [
70-
"ts-node/register",
71-
"source-map-support/register"
72-
],
73-
"sourceMap": true,
74-
"instrument": true
61+
"extends": "@istanbuljs/nyc-config-typescript"
7562
},
7663
"dependencies": {
7764
"async-file": "2.0.2",
@@ -96,6 +83,7 @@
9683
"yauzl": "2.10.0"
9784
},
9885
"devDependencies": {
86+
"@istanbuljs/nyc-config-typescript": "1.0.1",
9987
"@types/archiver": "2.1.2",
10088
"@types/chai": "4.1.7",
10189
"@types/chai-arrays": "1.0.2",
@@ -141,7 +129,7 @@
141129
"mock-http-server": "0.2.0",
142130
"natives": "1.1.6",
143131
"npm-run-all": "4.1.5",
144-
"nyc": "^15.0.0",
132+
"nyc": "15.0.1",
145133
"plist": "3.0.1",
146134
"remap-istanbul": "0.13.0",
147135
"source-map-support": "0.5.10",

0 commit comments

Comments
 (0)