File tree Expand file tree Collapse file tree 1 file changed +6
-2
lines changed Expand file tree Collapse file tree 1 file changed +6
-2
lines changed Original file line number Diff line number Diff line change @@ -11,21 +11,25 @@ import { Octokit } from '@octokit/rest';
11
11
interface Options {
12
12
releaseVersion : string ;
13
13
releaseCommit : string ;
14
- dryRun : boolean ;
14
+ // Even it is specified as boolean, it would still be parsed as string in compiled js.
15
+ dryRun : string ;
15
16
}
16
17
17
18
gulp . task ( 'createTags' , async ( ) : Promise < void > => {
18
19
const options = minimist < Options > ( process . argv . slice ( 2 ) ) ;
19
20
console . log ( `releaseVersion: ${ options . releaseVersion } ` ) ;
20
21
console . log ( `releaseCommit: ${ options . releaseCommit } ` ) ;
22
+ const dryRun = options . dryRun . toLocaleLowerCase ( ) === 'true' ;
23
+ console . log ( `dry run: ${ dryRun } ` ) ;
21
24
22
25
const roslynCommit = await findRoslynCommitAsync ( ) ;
23
26
if ( ! roslynCommit ) {
24
27
logError ( 'Failed to find roslyn commit.' ) ;
25
28
return ;
26
29
}
27
30
28
- if ( options . dryRun ) {
31
+ // The compiled option value in js type is 'any' type.
32
+ if ( dryRun ) {
29
33
console . log ( 'Tagging is skipped in dry run mode.' ) ;
30
34
return ;
31
35
} else {
You can’t perform that action at this time.
0 commit comments