File tree Expand file tree Collapse file tree 1 file changed +6
-2
lines changed Expand file tree Collapse file tree 1 file changed +6
-2
lines changed Original file line number Diff line number Diff line change @@ -11,21 +11,25 @@ import { Octokit } from '@octokit/rest';
1111interface Options {
1212 releaseVersion : string ;
1313 releaseCommit : string ;
14- dryRun : boolean ;
14+ // Even it is specified as boolean, it would still be parsed as string in compiled js.
15+ dryRun : string ;
1516}
1617
1718gulp . task ( 'createTags' , async ( ) : Promise < void > => {
1819 const options = minimist < Options > ( process . argv . slice ( 2 ) ) ;
1920 console . log ( `releaseVersion: ${ options . releaseVersion } ` ) ;
2021 console . log ( `releaseCommit: ${ options . releaseCommit } ` ) ;
22+ const dryRun = options . dryRun . toLocaleLowerCase ( ) === 'true' ;
23+ console . log ( `dry run: ${ dryRun } ` ) ;
2124
2225 const roslynCommit = await findRoslynCommitAsync ( ) ;
2326 if ( ! roslynCommit ) {
2427 logError ( 'Failed to find roslyn commit.' ) ;
2528 return ;
2629 }
2730
28- if ( options . dryRun ) {
31+ // The compiled option value in js type is 'any' type.
32+ if ( dryRun ) {
2933 console . log ( 'Tagging is skipped in dry run mode.' ) ;
3034 return ;
3135 } else {
You can’t perform that action at this time.
0 commit comments