showing the warning message

Author: akshita31

package.json

@@ -144,7 +144,7 @@
   "runtimeDependencies": [
     {
       "description": "OmniSharp for Windows (.NET 4.6 / x86)",
-      "url": "https://download.visualstudio.microsoft.com/download/pr/11655913/afaf4c0f0bee0304c8b1c55dfc190a9f/omnisharp-win-x86-1.29.1.zip",
+      "url": "https://nodejs.org/api/stream.html#stream_writable_write_chunk_encoding_callback",
       "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x86-1.29.1.zip",
       "installPath": ".omnisharp/1.29.1",
       "platforms": [
@@ -158,7 +158,7 @@
     },
     {
       "description": "OmniSharp for Windows (.NET 4.6 / x64)",
-      "url": "https://download.visualstudio.microsoft.com/download/pr/11655914/fc5dedbd95030e4015ffc24e48177255/omnisharp-win-x64-1.29.1.zip",
+      "url": "https://nodejs.org/api/stream.html#stream_writable_write_chunk_encoding_callback",
       "fallbackUrl": "https://omnisharpdownload.blob.core.windows.net/ext/omnisharp-win-x64-1.29.1.zip",
       "installPath": ".omnisharp/1.29.1",
       "platforms": [

src/observers/WarningMessageObserver.ts

@@ -3,11 +3,14 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import * as fs from 'async-file';
 import { MessageItem, vscode } from '../vscodeAdapter';
-import { BaseEvent, OmnisharpServerOnError, OmnisharpServerMsBuildProjectDiagnostics } from "../omnisharp/loggingEvents";
+import { BaseEvent, OmnisharpServerOnError, OmnisharpServerMsBuildProjectDiagnostics, ZipFileError } from "../omnisharp/loggingEvents";
 import { Scheduler } from 'rxjs/Scheduler';
 import { Subject } from 'rxjs/Subject';
 import 'rxjs/add/operator/debounceTime';
+import { CreateTmpFile } from '../CreateTmpAsset';
+import * as vscode1 from 'vscode';
 
 export interface MessageItemWithCommand extends MessageItem {
     command: string;
@@ -23,17 +26,12 @@ export class WarningMessageObserver {
             let value: MessageItemWithCommand;
             try {
                 value = await this.vscode.window.showWarningMessage<MessageItemWithCommand>(message, { title: "Show Output", command: 'o.showOutput' });
-            }
-            catch (err){
-                console.log(err);
-            }
-            if (value) {
-                try {
+                if (value) {
                     await this.vscode.commands.executeCommand<string>(value.command);
                 }
-                catch (err) {
-                    console.log(err);
-                }
+            }
+            catch (err) {
+                console.log(err);
             }
         });
     }
@@ -46,6 +44,9 @@ export class WarningMessageObserver {
             case OmnisharpServerMsBuildProjectDiagnostics.name:
                 this.handleOmnisharpServerMsBuildProjectDiagnostics(<OmnisharpServerMsBuildProjectDiagnostics>event);
                 break;
+            case ZipFileError.name:
+                this.handleZipFileError(<ZipFileError>event);
+                break;
         }
     }
 
@@ -54,4 +55,27 @@ export class WarningMessageObserver {
             this.warningMessageDebouncer.next(event);
         }
     }
+
+    private async handleZipFileError(event: ZipFileError) {
+        let tmpFile = await CreateTmpFile();
+        let writestream = fs.createWriteStream(tmpFile.name);
+        writestream.write(event.content);
+        //once we have written to the file show a warning message to open it
+        let value: MessageItemWithCommand;
+        let message = " The downloaded file is not a zip. Please review your proxy settings or view the downloaded file below.";
+        try {
+            //let file = "C:\\Users\\akagarw\\AppData\\Local\\Temp\\package-32592bbSNWBM3SWGP";
+            let file = vscode1.Uri.file(tmpFile.name);
+            value = await this.vscode.window.showWarningMessage<MessageItemWithCommand>(message, { title: "View downloaded file", command: 'vscode.open' });
+            if (value) {
+                await this.vscode.commands.executeCommand<string>(value.command,file);
+            }
+        }
+        catch (err) {
+            console.log(err);
+        }
+        finally {
+            tmpFile.dispose();
+        }
+    }
 }

src/omnisharp/loggingEvents.ts

@@ -118,6 +118,10 @@ export class DownloadSizeObtained implements BaseEvent {
     constructor(public packageSize: number) { }
 }
 
+export class ZipFileError implements BaseEvent {
+    constructor(public content: string) { }
+}
+
 export class DebuggerPrerequisiteFailure extends EventWithMessage { }
 export class DebuggerPrerequisiteWarning extends EventWithMessage { }
 export class CommandDotNetRestoreProgress extends EventWithMessage { }

src/packageManager/ZipInstaller.ts

@@ -8,15 +8,16 @@ import * as mkdirp from 'mkdirp';
 import * as path from 'path';
 import * as yauzl from 'yauzl';
 import { EventStream } from "../EventStream";
-import { InstallationStart } from "../omnisharp/loggingEvents";
+import { InstallationStart, ZipFileError } from "../omnisharp/loggingEvents";
 import { NestedError } from '../NestedError';
 
 export async function InstallZip(buffer: Buffer, description: string, destinationInstallPath: string, binaries: string[], eventStream: EventStream): Promise<void> {
     eventStream.post(new InstallationStart(description));
 
     return new Promise<void>((resolve, reject) => {
-        yauzl.fromBuffer(buffer, { lazyEntries: true }, (err, zipFile) => {
+        yauzl.fromBuffer(buffer, { lazyEntries: true }, async (err, zipFile) => {
             if (err) {
+                eventStream.post(new ZipFileError(buffer.toString()));
                 return reject(new NestedError('Immediate zip file error', err));
             }
 

src/vscodeAdapter.ts

@@ -899,7 +899,7 @@ export interface vscode {
     window: {
         activeTextEditor: TextEditor | undefined;
         showInformationMessage: (message: string, ...items: string[]) => Thenable<string | undefined>;
-        showWarningMessage: <T extends MessageItem>(message: string, ...items: T[]) => Thenable<T | undefined>;
+        showWarningMessage: <T extends MessageItem>(message: string, ...items: T[]) => Thenable<T | undefined>;       
     };
     workspace: {
         getConfiguration: (section?: string, resource?: Uri) => WorkspaceConfiguration;