Linesplit and ohmyzshfix (#1132)

* Renaming LaunchConfigurations

To LaunchBrowserPlatformOptions.

* Simplifying retrieving pipeTransport for attach

The launch.json configuration is passed in via the args parameter.
There is no need to read the launch.json file and find the correct
configuration. The old method would only grab the first launch json name
that matched. This change allows duplicate launch names but still grabs
the correct pipeTransport.

* Removing dead code

* Fixes for OhMyZsh and Line Splitting

Line splitting is dependant on program used. E.g. plink or ssh, so line
splitting for the processes given is handling both \r\n and just \n.

OhMyZsh fails with the current command. Fix is to add extra [] around
existing [].

* Fixing command to work for sh and adding error msg

If a user decides to launch the remoteProcessPicker and clicks outside
of the process picker window, it will try to attach to the process id
'null'. Adding in a new error message.

* Simplifying command

Author: WardenGnaw

src/features/processPicker.ts

@@ -84,7 +84,7 @@ export class RemoteAttachPicker {
                     placeHolder: "Select the process to attach to"
                 };
                 return vscode.window.showQuickPick(processes, attachPickOptions).then(item => {
-                    return item ? item.id : null;
+                    return item ? item.id : Promise.reject<string>(new Error("Could not find a process id to attach."));
                 });
             });
         }
@@ -119,13 +119,13 @@ export class RemoteAttachPicker {
 
     public static getRemoteOSAndProcesses(pipeCmd: string): Promise<AttachItem[]> {
         // Commands to get OS and processes
-        const command = `uname && if [ $(uname) == "Linux" ] ; then ${RemoteAttachPicker.linuxPsCommand} ; elif [ $(uname) == "Darwin" ] ; ` +
-            `then ${RemoteAttachPicker.osxPsCommand}; fi`;
+        const command = `bash -c 'uname && if [ $(uname) == "Linux" ] ; then ${RemoteAttachPicker.linuxPsCommand} ; elif [ $(uname) == "Darwin" ] ; ` +
+            `then ${RemoteAttachPicker.osxPsCommand}; fi'`;
 
         return execChildProcessAndOutputErrorToChannel(`${pipeCmd} "${command}"`, null, RemoteAttachPicker._channel).then(output => {
             // OS will be on first line
             // Processess will follow if listed
-            let lines = output.split(os.EOL);
+            let lines = output.split(/\r?\n/);
 
             if (lines.length == 0) {
                 return Promise.reject<AttachItem[]>(new Error("Pipe transport failed to get OS and processes."));