Merge pull request #7599 from dibarbet/async_lint

Enable no floating promises lint rule

Author: dibarbet

.eslintrc.js

@@ -4,7 +4,7 @@ module.exports = {
     },
     extends: [
         "eslint:recommended",
-        "plugin:@typescript-eslint/recommended"
+        "plugin:@typescript-eslint/recommended",
     ],
     parser: "@typescript-eslint/parser",
     parserOptions: {
@@ -33,6 +33,7 @@ module.exports = {
         ],
         "@typescript-eslint/no-namespace": "off",
         "@typescript-eslint/promise-function-async": "error",
+        "@typescript-eslint/no-floating-promises": "error",
         "prefer-promise-reject-errors": "error",
         "curly": "error",
         "prettier/prettier": [ "error", { "endOfLine": "auto" } ],

l10n/bundle.l10n.json

@@ -29,13 +29,13 @@
   "Can't parse envFile {0} because of {1}": "Can't parse envFile {0} because of {1}",
   "Open envFile": "Open envFile",
   "Yes": "Yes",
-  "Not Now": "Not Now",
-  "More Information": "More Information",
-  "The selected launch configuration is configured to launch a web browser but no trusted development certificate was found. Create a trusted self-signed certificate?": "The selected launch configuration is configured to launch a web browser but no trusted development certificate was found. Create a trusted self-signed certificate?",
   "Self-signed certificate sucessfully {0}": "Self-signed certificate sucessfully {0}",
   "Couldn't create self-signed certificate. {0}\ncode: {1}\nstdout: {2}": "Couldn't create self-signed certificate. {0}\ncode: {1}\nstdout: {2}",
   "Show Output": "Show Output",
   "Couldn't create self-signed certificate. See output for more information.": "Couldn't create self-signed certificate. See output for more information.",
+  "Not Now": "Not Now",
+  "More Information": "More Information",
+  "The selected launch configuration is configured to launch a web browser but no trusted development certificate was found. Create a trusted self-signed certificate?": "The selected launch configuration is configured to launch a web browser but no trusted development certificate was found. Create a trusted self-signed certificate?",
   "No executable projects": "No executable projects",
   "Select the project to launch": "Select the project to launch",
   "Invalid project index": "Invalid project index",
@@ -140,8 +140,8 @@
   "OmniSharp requires a complete install of Mono (including MSBuild) to provide language services when `omnisharp.useModernNet` is disabled in Settings. Please install the latest Mono and restart.": "OmniSharp requires a complete install of Mono (including MSBuild) to provide language services when `omnisharp.useModernNet` is disabled in Settings. Please install the latest Mono and restart.",
   "Download Mono": "Download Mono",
   "Open settings": "Open settings",
-  "dotnet.server.useOmnisharp option has changed. Please reload the window to apply the change": "dotnet.server.useOmnisharp option has changed. Please reload the window to apply the change",
   "Reload Window": "Reload Window",
+  "dotnet.server.useOmnisharp option has changed. Please reload the window to apply the change": "dotnet.server.useOmnisharp option has changed. Please reload the window to apply the change",
   "C# configuration has changed. Would you like to relaunch the Language Server with your changes?": "C# configuration has changed. Would you like to relaunch the Language Server with your changes?",
   "Restart Language Server": "Restart Language Server",
   "project.json is no longer a supported project format for .NET Core applications.": "project.json is no longer a supported project format for .NET Core applications.",

src/coreclrDebug/activate.ts

@@ -20,6 +20,7 @@ import { RemoteAttachPicker } from '../shared/processPicker';
 import CompositeDisposable from '../compositeDisposable';
 import { BaseVsDbgConfigurationProvider } from '../shared/configurationProvider';
 import { omnisharpOptions } from '../shared/options';
+import { ActionOption, showErrorMessage } from '../shared/observers/utils/showMessage';
 
 export async function activate(
     thisExtension: vscode.Extension<any>,
@@ -46,7 +47,7 @@ export async function activate(
             showInstallErrorMessage(eventStream);
         }
     } else if (!CoreClrDebugUtil.existsSync(debugUtil.installCompleteFilePath())) {
-        completeDebuggerInstall(debugUtil, platformInformation, eventStream);
+        await completeDebuggerInstall(debugUtil, platformInformation, eventStream);
     }
 
     // register process picker for attach for legacy configurations.
@@ -80,7 +81,7 @@ export async function activate(
                 }
             }
 
-            vscode.debug.startDebugging(
+            await vscode.debug.startDebugging(
                 undefined,
                 {
                     name: '.NET Core Attach',
@@ -183,7 +184,8 @@ async function completeDebuggerInstall(
         const isValidArchitecture = await checkIsValidArchitecture(platformInformation, eventStream);
         if (!isValidArchitecture) {
             eventStream.post(new DebuggerNotInstalledFailure());
-            vscode.window.showErrorMessage(
+            showErrorMessage(
+                vscode,
                 vscode.l10n.t(
                     'Failed to complete the installation of the C# extension. Please see the error in the output window below.'
                 )
@@ -192,7 +194,7 @@ async function completeDebuggerInstall(
         }
 
         // Write install.complete
-        CoreClrDebugUtil.writeEmptyFile(debugUtil.installCompleteFilePath());
+        await CoreClrDebugUtil.writeEmptyFile(debugUtil.installCompleteFilePath());
 
         return true;
     } catch (err) {
@@ -208,7 +210,8 @@ async function completeDebuggerInstall(
 
 function showInstallErrorMessage(eventStream: EventStream) {
     eventStream.post(new DebuggerNotInstalledFailure());
-    vscode.window.showErrorMessage(
+    showErrorMessage(
+        vscode,
         vscode.l10n.t(
             'An error occurred during installation of the .NET Debugger. The C# extension may need to be reinstalled.'
         )
@@ -218,22 +221,28 @@ function showInstallErrorMessage(eventStream: EventStream) {
 function showDotnetToolsWarning(message: string): void {
     const config = vscode.workspace.getConfiguration('csharp');
     if (!config.get('suppressDotnetInstallWarning', false)) {
-        const getDotNetMessage = vscode.l10n.t('Get the SDK');
-        const goToSettingsMessage = vscode.l10n.t('Disable message in settings');
-        const helpMessage = vscode.l10n.t('Help');
+        const getDotNetMessage: ActionOption = {
+            title: vscode.l10n.t('Get the SDK'),
+            action: async () => {
+                await vscode.env.openExternal(vscode.Uri.parse('https://dot.net/core-sdk-vscode'));
+            },
+        };
+        const goToSettingsMessage: ActionOption = {
+            title: vscode.l10n.t('Disable message in settings'),
+            action: async () => {
+                await vscode.commands.executeCommand('workbench.action.openGlobalSettings');
+            },
+        };
+        const helpMessage: ActionOption = {
+            title: vscode.l10n.t('Help'),
+            action: async () => {
+                await vscode.env.openExternal(vscode.Uri.parse('https://aka.ms/VSCode-CS-DotnetNotFoundHelp'));
+            },
+        };
+
         // Buttons are shown in right-to-left order, with a close button to the right of everything;
         // getDotNetMessage will be the first button, then goToSettingsMessage, then the close button.
-        vscode.window.showErrorMessage(message, goToSettingsMessage, getDotNetMessage, helpMessage).then((value) => {
-            if (value === getDotNetMessage) {
-                const dotnetcoreURL = 'https://dot.net/core-sdk-vscode';
-                vscode.env.openExternal(vscode.Uri.parse(dotnetcoreURL));
-            } else if (value === goToSettingsMessage) {
-                vscode.commands.executeCommand('workbench.action.openGlobalSettings');
-            } else if (value == helpMessage) {
-                const helpURL = 'https://aka.ms/VSCode-CS-DotnetNotFoundHelp';
-                vscode.env.openExternal(vscode.Uri.parse(helpURL));
-            }
-        });
+        showErrorMessage(vscode, message, goToSettingsMessage, getDotNetMessage, helpMessage);
     }
 }
 

src/createTmpAsset.ts

@@ -43,7 +43,9 @@ export async function CreateTmpDir(unsafeCleanup: boolean): Promise<TmpAsset> {
         name: tmpDir.name,
         dispose: () => {
             if (unsafeCleanup) {
-                rimraf(tmpDir.name); //to delete directories that have folders inside them
+                rimraf(tmpDir.name).catch((rejectReason) => {
+                    throw new Error(`Failed to cleanup ${tmpDir.name} at ${tmpDir.fd}: ${rejectReason}`);
+                }); //to delete directories that have folders inside them
             } else {
                 tmpDir.removeCallback();
             }

src/lsptoolshost/commands.ts

@@ -187,7 +187,7 @@ async function openSolution(languageServer: RoslynLanguageServer): Promise<vscod
 
     if (launchTarget) {
         const uri = vscode.Uri.file(launchTarget.target);
-        languageServer.openSolution(uri);
+        await languageServer.openSolution(uri);
         return uri;
     }
 }

src/lsptoolshost/languageStatusBar.ts

@@ -74,6 +74,10 @@ class ProjectContextStatus {
         projectContextService.onActiveFileContextChanged((e) => {
             item.text = e.context._vs_label;
         });
-        projectContextService.refresh();
+
+        // Trigger a refresh, but don't block creation on the refresh completing.
+        projectContextService.refresh().catch((e) => {
+            throw new Error(`Error refreshing project context status ${e}`);
+        });
     }
 }

src/lsptoolshost/onAutoInsert.ts

@@ -110,7 +110,7 @@ async function applyAutoInsertEdit(
         }
 
         if (response.command !== undefined) {
-            vscode.commands.executeCommand(response.command.command, response.command.arguments);
+            await vscode.commands.executeCommand(response.command.command, response.command.arguments);
         }
     }
 }

src/lsptoolshost/optionChanges.ts

@@ -7,8 +7,8 @@ import * as vscode from 'vscode';
 import { Observable } from 'rxjs';
 import { CommonOptionsThatTriggerReload, LanguageServerOptionsThatTriggerReload } from '../shared/options';
 import { HandleOptionChanges, OptionChangeObserver, OptionChanges } from '../shared/observers/optionChangeObserver';
-import ShowInformationMessage from '../shared/observers/utils/showInformationMessage';
 import Disposable from '../disposable';
+import { CommandOption, showInformationMessage } from '../shared/observers/utils/showMessage';
 
 export function registerLanguageServerOptionChanges(optionObservable: Observable<void>): Disposable {
     const optionChangeObserver: OptionChangeObserver = {
@@ -34,19 +34,18 @@ function handleLanguageServerOptionChanges(changedOptions: OptionChanges): void
         return;
     }
 
-    const reloadTitle = vscode.l10n.t('Reload Window');
-    const reloadCommand = 'workbench.action.reloadWindow';
+    const reloadTitle: CommandOption = {
+        title: vscode.l10n.t('Reload Window'),
+        command: 'workbench.action.reloadWindow',
+    };
     if (changedOptions.changedCommonOptions.find((key) => key === 'useOmnisharpServer')) {
         // If the user has changed the useOmnisharpServer flag we need to reload the window.
-        ShowInformationMessage(
+        showInformationMessage(
             vscode,
             vscode.l10n.t(
                 'dotnet.server.useOmnisharp option has changed. Please reload the window to apply the change'
             ),
-            {
-                title: reloadTitle,
-                command: reloadCommand,
-            }
+            reloadTitle
         );
         return;
     }
@@ -56,5 +55,5 @@ function handleLanguageServerOptionChanges(changedOptions: OptionChanges): void
     const message = vscode.l10n.t(
         'C# configuration has changed. Would you like to reload the window to apply your changes?'
     );
-    ShowInformationMessage(vscode, message, { title: reloadTitle, command: reloadCommand });
+    showInformationMessage(vscode, message, reloadTitle);
 }

src/lsptoolshost/restore.ts

@@ -13,6 +13,7 @@ import {
     ProjectNeedsRestoreRequest,
 } from './roslynProtocol';
 import path = require('path');
+import { showErrorMessage } from '../shared/observers/utils/showMessage';
 
 let _restoreInProgress = false;
 
@@ -79,7 +80,7 @@ export async function restore(
     showOutput: boolean
 ): Promise<void> {
     if (_restoreInProgress) {
-        vscode.window.showErrorMessage(vscode.l10n.t('Restore already in progress'));
+        showErrorMessage(vscode, vscode.l10n.t('Restore already in progress'));
         return;
     }
     _restoreInProgress = true;