Fix chai test assertion library usages

Author: dibarbet

test/featureTests/assets.test.ts

@@ -15,11 +15,14 @@ import {
     updateJsonWithComments,
 } from '../../src/shared/assets';
 import { parse } from 'jsonc-parser';
-import { should } from 'chai';
+import { use, should } from 'chai';
+import * as chaiString from 'chai-string';
 import { ProjectDebugInformation } from '../../src/shared/IWorkspaceDebugInformationProvider';
 import { findNetCoreTargetFramework } from '../../src/shared/utils';
 import { isNotNull } from '../testUtil';
 
+use(chaiString);
+
 suite('Asset generation: csproj', () => {
     suiteSetup(() => should());
 

test/integrationTests/completionProvider.integration.test.ts

@@ -7,9 +7,12 @@ import OmniSharpCompletionProvider from '../../src/features/completionProvider';
 import * as vscode from 'vscode';
 import testAssetWorkspace from './testAssets/testAssetWorkspace';
 import * as path from 'path';
-import { expect, should } from 'chai';
+import { use, expect, should } from 'chai';
+import * as chaiArray from 'chai-arrays';
 import { activateCSharpExtension, isRazorWorkspace, isSlnWithGenerator } from './integrationHelpers';
 
+use(chaiArray);
+
 suite(`${OmniSharpCompletionProvider.name}: Returns the completion items`, () => {
     let fileUri: vscode.Uri;
 

test/integrationTests/documentationCommentAutoFormatting.integration.test.ts

@@ -3,12 +3,15 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { expect, should } from 'chai';
+import { use, expect, should } from 'chai';
+import * as chaiArray from 'chai-arrays';
 import * as vscode from 'vscode';
 import * as path from 'path';
 import { isRazorWorkspace, isSlnWithGenerator } from './integrationHelpers';
 import testAssetWorkspace from './testAssets/testAssetWorkspace';
 
+use(chaiArray);
+
 const onTypeFormatProviderCommand = 'vscode.executeFormatOnTypeProvider';
 
 function normalizeNewlines(original: string): string {

test/unitTests/logging/dotnetTestLoggerObserver.test.ts

@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as chai from 'chai';
+import * as chaiString from 'chai-string';
 import { getNullChannel } from '../testAssets/fakes';
 import {
     EventWithMessage,
@@ -24,6 +25,7 @@ import DotNetTestLoggerObserver from '../../../src/observers/dotnetTestLoggerObs
 import * as protocol from '../../../src/omnisharp/protocol';
 
 const expect = chai.expect;
+chai.use(chaiString);
 
 suite(`${DotNetTestLoggerObserver.name}`, () => {
     let appendedMessage: string;

test/unitTests/logging/omnisharpDebugModeLoggerObserver.test.ts

@@ -2,7 +2,8 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-import { should, expect } from 'chai';
+import { use, should, expect } from 'chai';
+import * as chaiString from 'chai-string';
 import { getNullChannel } from '../testAssets/fakes';
 import {
     OmnisharpServerVerboseMessage,
@@ -17,6 +18,8 @@ import {
 } from '../../../src/omnisharp/loggingEvents';
 import { OmnisharpDebugModeLoggerObserver } from '../../../src/observers/omnisharpDebugModeLoggerObserver';
 
+use(chaiString);
+
 suite('OmnisharpDebugModeLoggerObserver', () => {
     suiteSetup(() => should());
     let logOutput = '';

test/unitTests/logging/telemetryObserver.test.ts

@@ -2,7 +2,8 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-import { should, expect } from 'chai';
+import { use, should, expect } from 'chai';
+import * as chaiArray from 'chai-arrays';
 import { TelemetryObserver } from '../../../src/observers/telemetryObserver';
 import { PlatformInformation } from '../../../src/shared/platform';
 import {
@@ -22,6 +23,8 @@ import { Package } from '../../../src/packageManager/package';
 import { PackageError } from '../../../src/packageManager/packageError';
 import { isNotNull } from '../../testUtil';
 
+use(chaiArray);
+
 suite('TelemetryReporterObserver', () => {
     suiteSetup(() => should());
     const platformInfo = new PlatformInformation('linux', 'architecture');

test/unitTests/parsedEnvironmentFile.test.ts

@@ -4,7 +4,10 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { ParsedEnvironmentFile } from '../../src/coreclrDebug/parsedEnvironmentFile';
-import { should, expect } from 'chai';
+import { use, should, expect } from 'chai';
+import * as chaiString from 'chai-string';
+
+use(chaiString);
 
 suite('ParsedEnvironmentFile', () => {
     suiteSetup(() => should());