Make tasks nullable-aware

Author: winstliu

tasks/offlinePackagingTasks.ts

@@ -73,9 +73,10 @@ async function doPackageOffline() {
             await doOfflinePackage(p.platformInfo, p.id, p.isFramework, packageJSON, packedVsixOutputRoot);
         }
         catch (err) {
+            const message = (err instanceof Error ? err.stack : err) ?? '<unknown error>';
             // NOTE: Extra `\n---` at the end is because gulp will print this message following by the
             // stack trace of this line. So that seperates the two stack traces.
-            throw Error(`Failed to create package ${p.id}. ${err.stack ?? err ?? '<unknown error>'}\n---`);
+            throw Error(`Failed to create package ${p.id}. ${message}\n---`);
         }
     }
 }

tasks/spawnNode.ts

@@ -23,9 +23,9 @@ export default async function spawnNode(args?: string[], options?: SpawnSyncOpti
         stdio: "inherit"
     };
 
-    console.log(`starting ${nodePath} ${args.join(' ')}`);
+    console.log(`starting ${nodePath} ${args ? args.join(' ') : ''}`);
 
     const buffer = spawnSync(nodePath, args, optionsWithFullEnvironment);
 
     return { code: buffer.status, signal: buffer.signal };
-}
+}

tasks/testTasks.ts

@@ -18,7 +18,7 @@ gulp.task("test:feature", async () => {
 
     const result = await spawnNode([featureTestRunnerPath], { env });
 
-    if (result.code > 0) {
+    if (result.code === null || result.code > 0) {
         // Ensure that gulp fails when tests fail
         throw new Error(`Exit code: ${result.code}  Signal: ${result.signal}`);
     }
@@ -35,7 +35,7 @@ gulp.task("test:unit", async () => {
         'test/unitTests/**/*.test.ts'
     ]);
 
-    if (result.code > 0) {
+    if (result.code === null || result.code > 0) {
         // Ensure that gulp fails when tests fail
         throw new Error(`Exit code: ${result.code}  Signal: ${result.signal}`);
     }
@@ -83,7 +83,7 @@ async function runIntegrationTest(testAssetName: string) {
 
     const result = await spawnNode([integrationTestRunnerPath], { env, cwd: rootPath });
 
-    if (result.code > 0) {
+    if (result.code === null || result.code > 0) {
         // Ensure that gulp fails when tests fail
         throw new Error(`Exit code: ${result.code}  Signal: ${result.signal}`);
     }