review feedback

Author: dibarbet

.devcontainer/devcontainer.json

@@ -56,5 +56,5 @@
       ]
     }
   },
-  "postCreateCommand": "npm i && npx gulp installDependencies && npm i -g gulp"
+  "postCreateCommand": "npm ci && npx gulp installDependencies && npm i -g gulp"
 }

CHANGELOG.md

@@ -5,6 +5,9 @@
 * Bump xamltools to 17.13.35521.31 (PR: [#7814](https://github.com/dotnet/vscode-csharp/pull/7814))
 
 # 2.59.x
+* Delete `dotnet.dotnetPath` setting and support automatic migration to replacements (PR: [#7825](https://github.com/dotnet/vscode-csharp/pull/7825))
+  * Existing `dotnet.dotnetPath` values will be migrated to the .NET Install Tool extension's `dotnetAcquisitionExtension.existingDotnetPath` setting.  See [this page](https://github.com/dotnet/vscode-dotnet-runtime/blob/main/vscode-dotnet-runtime-extension/README.md#i-already-have-a-net-runtime-or-sdk-installed-and-i-want-to-use-it) for more details on configuring the .NET Install Tool.
+  * The OmniSharp version of `dotnet.dotnetPath` has been migrated to `omnisharp.dotnetPath`
 
 # 2.58.x
 * Update Razor to 9.0.0-preview.24569.4 (PR: [#7805](https://github.com/dotnet/vscode-csharp/pull/7805))

src/utils/dotnetDevCertsHttps.ts

@@ -9,14 +9,12 @@ import { commonOptions, omnisharpOptions } from '../shared/options';
 
 // Will return true if `dotnet dev-certs https --check` succesfully finds a trusted development certificate.
 export async function hasDotnetDevCertsHttps(): Promise<ExecReturnData> {
-    const dotnetPath = (commonOptions.useOmnisharpServer ? omnisharpOptions.dotnetPath : undefined) ?? 'dotnet';
-    return await execChildProcess(`${dotnetPath} dev-certs https --check --trust`, process.cwd(), process.env);
+    return await execChildProcess(`${getDotnetCommand()} dev-certs https --check --trust`, process.cwd(), process.env);
 }
 
 // Will run `dotnet dev-certs https --trust` to prompt the user to create a trusted self signed certificates. Retruns true if sucessfull.
 export async function createSelfSignedCert(): Promise<ExecReturnData> {
-    const dotnetPath = (commonOptions.useOmnisharpServer ? omnisharpOptions.dotnetPath : undefined) ?? 'dotnet';
-    return await execChildProcess(`${dotnetPath} dev-certs https --trust`, process.cwd(), process.env);
+    return await execChildProcess(`${getDotnetCommand()} dev-certs https --trust`, process.cwd(), process.env);
 }
 
 async function execChildProcess(
@@ -31,6 +29,14 @@ async function execChildProcess(
     });
 }
 
+function getDotnetCommand(): string {
+    if (commonOptions.useOmnisharpServer) {
+        return omnisharpOptions.dotnetPath ?? 'dotnet';
+    } else {
+        return 'dotnet';
+    }
+}
+
 interface ExecReturnData {
     error: cp.ExecException | null;
     stdout: string;