Skip to content

Commit 9c5bfb8

Browse files
committed
add some tests
1 parent 6510804 commit 9c5bfb8

File tree

2 files changed

+36
-16
lines changed

2 files changed

+36
-16
lines changed

test/unitTests/logging/CsharpChannelObserver.test.ts

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { should, expect } from 'chai';
77
import { getNullChannel } from '../testAssets/Fakes';
88
import { CsharpChannelObserver } from '../../../src/observers/CsharpChannelObserver';
9-
import { InstallationFailure, DebuggerNotInstalledFailure, DebuggerPrerequisiteFailure, ProjectJsonDeprecatedWarning, BaseEvent, PackageInstallStart } from '../../../src/omnisharp/loggingEvents';
9+
import { InstallationFailure, DebuggerNotInstalledFailure, DebuggerPrerequisiteFailure, ProjectJsonDeprecatedWarning, BaseEvent, PackageInstallStart, IntegrityCheckFailure } from '../../../src/omnisharp/loggingEvents';
1010

1111
suite("CsharpChannelObserver", () => {
1212
suiteSetup(() => should());
@@ -29,20 +29,24 @@ suite("CsharpChannelObserver", () => {
2929
});
3030
});
3131

32-
test(`${PackageInstallStart.name}: Channel is shown and preserveFocus is set to true`, () => {
33-
let hasShown = false;
34-
let preserveFocus = false;
35-
let event = new PackageInstallStart();
36-
let observer = new CsharpChannelObserver({
37-
...getNullChannel(),
38-
show: (preserve) => {
39-
hasShown = true;
40-
preserveFocus = preserve;
41-
}
42-
});
32+
[
33+
new IntegrityCheckFailure("", "", true),
34+
new PackageInstallStart()
35+
].forEach((event: BaseEvent) => {
36+
test(`${event.constructor.name}: Channel is shown and preserveFocus is set to true`, () => {
37+
let hasShown = false;
38+
let preserveFocus = false;
39+
let observer = new CsharpChannelObserver({
40+
...getNullChannel(),
41+
show: (preserve) => {
42+
hasShown = true;
43+
preserveFocus = preserve;
44+
}
45+
});
4346

44-
observer.post(event);
45-
expect(hasShown).to.be.true;
46-
expect(preserveFocus).to.be.true;
47-
})
47+
observer.post(event);
48+
expect(hasShown).to.be.true;
49+
expect(preserveFocus).to.be.true;
50+
});
51+
});
4852
});

test/unitTests/logging/CsharpLoggerObserver.test.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,4 +158,20 @@ suite("CsharpLoggerObserver", () => {
158158
observer.post(event);
159159
expect(logOutput).to.contain(event.fallbackUrl);
160160
});
161+
162+
test(`${Event.IntegrityCheckFailure.name}: Package Description is logged when we are retrying`, () => {
163+
let description = 'someDescription';
164+
let url = 'someUrl';
165+
let event = new Event.IntegrityCheckFailure(description, url, true);
166+
observer.post(event);
167+
expect(logOutput).to.contain(description);
168+
});
169+
170+
test(`${Event.IntegrityCheckFailure.name}: Package Description and url are logged when we are not retrying`, () => {
171+
let description = 'someDescription';
172+
let url = 'someUrl';
173+
let event = new Event.IntegrityCheckFailure(description, url, true);
174+
observer.post(event);
175+
expect(logOutput).to.contain(description);
176+
});
161177
});

0 commit comments

Comments
 (0)