Merge pull request #7037 from dibarbet/intellicode_activation_failure

Gracefully handle failures activating the intellicode extension

Author: dibarbet

l10n/bundle.l10n.json

@@ -135,6 +135,9 @@
   "Choose": "Choose",
   "Choose and set default": "Choose and set default",
   "Do not load any": "Do not load any",
+  "IntelliCode features will not be available, {0} failed to activate.": "IntelliCode features will not be available, {0} failed to activate.",
+  "Go to output": "Go to output",
+  "Suppress notification": "Suppress notification",
   "Restore {0}": "Restore {0}",
   "Restore already in progress": "Restore already in progress",
   "Restore": "Restore",

src/lsptoolshost/roslynLanguageServer.ts

@@ -529,7 +529,8 @@ export class RoslynLanguageServer {
             if (csharpDevkitIntelliCodeExtension) {
                 _channel.appendLine('Activating C# + C# Dev Kit + C# IntelliCode...');
                 const csharpDevkitIntelliCodeArgs = await this.getCSharpDevkitIntelliCodeExportArgs(
-                    csharpDevkitIntelliCodeExtension
+                    csharpDevkitIntelliCodeExtension,
+                    context
                 );
                 args = args.concat(csharpDevkitIntelliCodeArgs);
             } else {
@@ -822,14 +823,48 @@ export class RoslynLanguageServer {
     }
 
     private static async getCSharpDevkitIntelliCodeExportArgs(
-        csharpDevkitIntelliCodeExtension: vscode.Extension<CSharpIntelliCodeExports>
+        csharpDevkitIntelliCodeExtension: vscode.Extension<CSharpIntelliCodeExports>,
+        extensionContext: vscode.ExtensionContext
     ): Promise<string[]> {
-        const exports = await csharpDevkitIntelliCodeExtension.activate();
+        try {
+            const exports = await csharpDevkitIntelliCodeExtension.activate();
+
+            const starredCompletionComponentPath = exports.components['@vsintellicode/starred-suggestions-csharp'];
+
+            const csharpIntelliCodeArgs: string[] = [
+                '--starredCompletionComponentPath',
+                starredCompletionComponentPath,
+            ];
+            return csharpIntelliCodeArgs;
+        } catch (e) {
+            _channel.appendLine(`Activation of ${csharpDevkitIntelliCodeExtensionId} failed`);
+            _channel.appendLine(e instanceof Error ? e.message : (e as string));
+            if (e instanceof Error && e.stack) {
+                _channel.appendLine(e.stack);
+            }
+
+            const stateKey = 'disableIntellicodeFailedPopup';
+            if (extensionContext.globalState.get(stateKey) === true) {
+                return [];
+            }
 
-        const starredCompletionComponentPath = exports.components['@vsintellicode/starred-suggestions-csharp'];
+            const message = vscode.l10n.t(
+                'IntelliCode features will not be available, {0} failed to activate.',
+                csharpDevkitIntelliCodeExtensionId
+            );
+            const showOutput = vscode.l10n.t('Go to output');
+            const suppressNotification = vscode.l10n.t('Suppress notification');
+            // Buttons are shown in right-to-left order, with a close button to the right of everything;
+            vscode.window.showErrorMessage(message, showOutput, suppressNotification).then((value) => {
+                if (value === showOutput) {
+                    _channel.show();
+                } else if (value == suppressNotification) {
+                    extensionContext.globalState.update(stateKey, true);
+                }
+            });
 
-        const csharpIntelliCodeArgs: string[] = ['--starredCompletionComponentPath', starredCompletionComponentPath];
-        return csharpIntelliCodeArgs;
+            return [];
+        }
     }
 
     private static async setupDevKitEnvironment(