Ensure that the value of strictSSL is respected even if a proxy isn't set

Author: DustinCampbell

src/common.ts

@@ -25,6 +25,10 @@ export function getBinPath() {
     return path.resolve(getExtensionPath(), "bin");
 }
 
+export function isBoolean(obj: any): obj is boolean {
+    return obj === true || obj === false;
+}
+
 export function buildPromiseChain<T, TResult>(array: T[], builder: (item: T) => Promise<TResult>): Promise<TResult> {
     return array.reduce(
         (promise, n) => promise.then(() => builder(n)),

src/packages.ts

@@ -173,7 +173,8 @@ function downloadFile(urlString: string, pkg: Package, logger: Logger, status: S
     const options: https.RequestOptions = {
         host: url.host,
         path: url.path,
-        agent: getProxyAgent(url, proxy, strictSSL)
+        agent: getProxyAgent(url, proxy, strictSSL),
+        rejectUnauthorized: util.isBoolean(strictSSL) ? strictSSL : true
     };
 
     return new Promise<void>((resolve, reject) => {

src/proxy.ts

@@ -6,6 +6,7 @@
 'use strict';
 
 import { Url, parse as parseUrl } from 'url';
+import { isBoolean } from './common';
 import HttpProxyAgent = require('http-proxy-agent');
 import HttpsProxyAgent = require('https-proxy-agent');
 
@@ -32,15 +33,11 @@ export function getProxyAgent(requestURL: Url, proxy: string, strictSSL: boolean
         return null;
     }
 
-    if (strictSSL === undefined) {
-        strictSSL = true;
-    }
-
     const opts = {
         host: proxyEndpoint.hostname,
         port: Number(proxyEndpoint.port),
         auth: proxyEndpoint.auth,
-        rejectUnauthorized: strictSSL
+        rejectUnauthorized: isBoolean(strictSSL) ? strictSSL : true
     };
 
     return requestURL.protocol === 'http:' ? new HttpProxyAgent(opts) : new HttpsProxyAgent(opts);