Skip to content

Commit aa6fe5e

Browse files
committed
requested changes
1 parent d7c2787 commit aa6fe5e

File tree

7 files changed

+7
-9
lines changed

7 files changed

+7
-9
lines changed

src/observers/OmnisharpDebugModeLoggerObserver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class OmnisharpDebugModeLoggerObserver extends BaseLoggerObserver {
6262
}
6363

6464
private handleOmnisharpProcessRequestStart(event: OmnisharpServerProcessRequestStart) {
65-
this.logger.appendLine(`Processing ${event.name} queue, empty slots ${event.slots}`);
65+
this.logger.appendLine(`Processing ${event.name} queue, available slots ${event.availableRequestSlots}`);
6666
this.logger.increaseIndent();
6767
}
6868

src/omnisharp/EventType.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export enum EventType {
8383
DotNetTestRunInContextStart = 76,
8484
DotNetTestDebugInContextStart = 77,
8585
TelemetryErrorEvent = 78,
86-
OmnisharpServerRequestCancelled = 79
86+
OmnisharpServerRequestCancelled = 79,
8787
}
8888

8989
//Note that the EventType protocol is shared with Razor.VSCode and the numbers here should not be altered

src/omnisharp/loggingEvents.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ export class OmnisharpServerRequestCancelled implements BaseEvent {
130130

131131
export class OmnisharpServerProcessRequestStart implements BaseEvent {
132132
type = EventType.OmnisharpServerProcessRequestStart;
133-
constructor(public name: string, public slots: number) { }
133+
constructor(public name: string, public availableRequestSlots: number) { }
134134
}
135135

136136
export class OmnisharpEventPacketReceived implements BaseEvent {

src/omnisharp/prioritization.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ const priorityCommands = [
1515
const normalCommands = [
1616
protocol.Requests.Completion,
1717
protocol.Requests.CompletionResolve,
18-
protocol.Requests.AutoComplete,
1918
protocol.Requests.FilesChanged,
2019
protocol.Requests.FindSymbols,
2120
protocol.Requests.FindUsages,

src/omnisharp/protocol.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { CompletionTriggerKind, CompletionItemKind, CompletionItemTag, InsertTex
88

99
export module Requests {
1010
export const AddToProject = '/addtoproject';
11-
export const AutoComplete = '/autocomplete';
1211
export const CodeCheck = '/codecheck';
1312
export const CodeFormat = '/codeformat';
1413
export const ChangeBuffer = '/changebuffer';

src/omnisharp/requestQueue.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,10 @@ class RequestQueue {
8888
return;
8989
}
9090

91-
const slots = this._maxSize - this._waiting.size;
92-
this.eventStream.post(new OmnisharpServerProcessRequestStart(this._name, slots));
91+
const availableRequestSlots = this._maxSize - this._waiting.size;
92+
this.eventStream.post(new OmnisharpServerProcessRequestStart(this._name, availableRequestSlots));
9393

94-
for (let i = 0; i < slots && this._pending.length > 0; i++) {
94+
for (let i = 0; i < availableRequestSlots && this._pending.length > 0; i++) {
9595
const item = this._pending.shift();
9696
item.startTime = Date.now();
9797

test/unitTests/logging/OmnisharpDebugModeLoggerObserver.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ suite("OmnisharpDebugModeLoggerObserver", () => {
5050
let event = new OmnisharpServerProcessRequestStart("foobar", 2);
5151
observer.post(event);
5252
expect(logOutput).to.contain(event.name);
53-
expect(logOutput).to.contain(event.slots);
53+
expect(logOutput).to.contain(event.availableRequestSlots);
5454
});
5555

5656
test(`OmnisharpServerRequestCancelled: Name and Id is logged`, () => {

0 commit comments

Comments
 (0)