Code review feedback for hasWebDependency function

DustinCampbell · DustinCampbell · commit b5d2fd6779b0 · 2016-07-20T07:24:15.000-07:00
diff --git a/src/assets.ts b/src/assets.ts
@@ -321,9 +321,9 @@ function findExecutableProjects(projects: protocol.DotNetProject[], configName:
     return result;
 }
 
-function hasWebServerDependency(targetProjectData: TargetProjectData) {
+function hasWebServerDependency(targetProjectData: TargetProjectData): boolean {
     if (!targetProjectData || !targetProjectData.projectJsonPath) {
-        return;
+        return false;
     }
 
     let projectJson = fs.readFileSync(targetProjectData.projectJsonPath, 'utf8');

Original file line number	Diff line number	Diff line change
`@@ -321,9 +321,9 @@ function findExecutableProjects(projects: protocol.DotNetProject[], configName:`
`321`	`321`	`return result;`
`322`	`322`	`}`
`323`	`323`
`324`		`-function hasWebServerDependency(targetProjectData: TargetProjectData) {`
	`324`	`+function hasWebServerDependency(targetProjectData: TargetProjectData): boolean {`
`325`	`325`	`if (!targetProjectData \|\| !targetProjectData.projectJsonPath) {`
`326`		`- return;`
	`326`	`+ return false;`
`327`	`327`	`}`
`328`	`328`
`329`	`329`	`let projectJson = fs.readFileSync(targetProjectData.projectJsonPath, 'utf8');`