Merge pull request #2836 from savpek/feature/enableroslynanalyzers-flag

enableRoslynAnalyzers flag.

Author: akshita31

package.json

@@ -704,6 +704,11 @@
           "default": false,
           "description": "If true, MSBuild project system will only load projects for files that were opened in the editor. This setting is useful for big C# codebases and allows for faster initialization of code navigation features only for projects that are relevant to code that is being edited. With this setting enabled OmniSharp may load fewer projects and may thus display incomplete reference lists for symbols."
         },
+        "omnisharp.enableRoslynAnalyzers": {
+          "type": "boolean",
+          "default": false,
+          "description": "Enables support for roslyn analyzers, code fixes and rulesets."
+        },
         "razor.plugin.path": {
           "type": [
             "string",

src/omnisharp/options.ts

@@ -25,12 +25,12 @@ export class Options {
         public razorDisabled: boolean,
         public razorDevMode: boolean,
         public enableMsBuildLoadProjectsOnDemand: boolean,
+        public enableRoslynAnalyzers: boolean,
         public razorPluginPath?: string,
         public defaultLaunchSolution?: string,
         public monoPath?: string,
         public maxProjectFileCountForDiagnosticAnalysis?: number | null) { }
 
-
     public static Read(vscode: vscode): Options {
         // Extra effort is taken below to ensure that legacy versions of options
         // are supported below. In particular, these are:
@@ -62,6 +62,8 @@ export class Options {
         const defaultLaunchSolution = omnisharpConfig.get<string>('defaultLaunchSolution', undefined);
         const useEditorFormattingSettings = omnisharpConfig.get<boolean>('useEditorFormattingSettings', true);
 
+        const enableRoslynAnalyzers = omnisharpConfig.get<boolean>('enableRoslynAnalyzers', false);
+
         const useFormatting = csharpConfig.get<boolean>('format.enable', true);
 
         const showReferencesCodeLens = csharpConfig.get<boolean>('referencesCodeLens.enabled', true);
@@ -101,6 +103,7 @@ export class Options {
             razorDisabled,
             razorDevMode,
             enableMsBuildLoadProjectsOnDemand,
+            enableRoslynAnalyzers,
             razorPluginPath,
             defaultLaunchSolution,
             monoPath,

src/omnisharp/server.ts

@@ -327,6 +327,10 @@ export class OmniSharpServer {
             args.push('MsBuild:LoadProjectsOnDemand=true');
         }
 
+        if (options.enableRoslynAnalyzers === true) {
+            args.push('RoslynExtensionsOptions:EnableAnalyzersSupport=true');
+        }
+
         let launchInfo: LaunchInfo;
         try {
             launchInfo = await this._omnisharpManager.GetOmniSharpLaunchInfo(this.packageJSON.defaults.omniSharp, options.path, serverUrl, latestVersionFileServerPath, installPath, this.extensionPath);

test/unitTests/optionStream.test.ts

@@ -51,6 +51,7 @@ suite('OptionStream', () => {
             options.minFindSymbolsFilterLength.should.equal(0);
             options.maxFindSymbolsItems.should.equal(1000);
             options.enableMsBuildLoadProjectsOnDemand.should.equal(false);
+            options.enableRoslynAnalyzers.should.equal(false);
             expect(options.defaultLaunchSolution).to.be.undefined;
         });
 

test/unitTests/options.test.ts

@@ -31,6 +31,7 @@ suite("Options tests", () => {
         options.minFindSymbolsFilterLength.should.equal(0);
         options.maxFindSymbolsItems.should.equal(1000);
         options.enableMsBuildLoadProjectsOnDemand.should.equal(false);
+        options.enableRoslynAnalyzers.should.equal(false);
         expect(options.defaultLaunchSolution).to.be.undefined;
     });