Remove the case and add the test

Author: akshita31

src/observers/CsharpLoggerObserver.ts

@@ -83,7 +83,7 @@ export class CsharpLoggerObserver extends BaseLoggerObserver {
             this.logger.appendLine(`Package ${event.packageDescription} failed integrity check. Retrying..`);
         }
         else {
-            this.logger.appendLine(`Package ${event.packageDescription} failed integrity check. Some features may not work as expected. Please restart Visual Studio Code to retrigger the download or download the package manually from ${event.url}`); 
+            this.logger.appendLine(`Package ${event.packageDescription} download from ${event.url} failed integrity check. Some features may not work as expected. Please restart Visual Studio Code to retrigger the download.`); 
         }
     }
 

src/observers/ErrorMessageObserver.ts

@@ -29,7 +29,7 @@ export class ErrorMessageObserver {
 
     handleIntegrityCheckFailure(event: IntegrityCheckFailure) {
         if (!event.retry) {
-            showErrorMessage(this.vscode, `Package ${event.packageDescription} failed integrity check. Some features may not work as expected. Please restart Visual Studio Code to retrigger the download or download the package manually from ${event.url}`);
+            showErrorMessage(this.vscode, `Package ${event.packageDescription} download from ${event.url} failed integrity check. Some features may not work as expected. Please restart Visual Studio Code to retrigger the download`);
         }
     }
 

test/unitTests/logging/CsharpLoggerObserver.test.ts

@@ -170,11 +170,12 @@ suite("CsharpLoggerObserver", () => {
     test(`${Event.IntegrityCheckFailure.name}: Package Description and url are logged when we are not retrying`, () => {
         let description = 'someDescription';
         let url = 'someUrl';
-        let event = new Event.IntegrityCheckFailure(description, url, true);
+        let event = new Event.IntegrityCheckFailure(description, url, false);
         observer.post(event);
         expect(logOutput).to.contain(description);
+        expect(logOutput).to.contain(url);
     });
-
+    
     test(`${Event.IntegrityCheckSuccess.name}: Some message is logged`, () => {
         let event = new Event.IntegrityCheckSuccess();
         observer.post(event);

test/unitTests/logging/ErrorMessageObserver.test.ts

@@ -9,7 +9,7 @@ import { getFakeVsCode } from '../testAssets/Fakes';
 import 'rxjs/add/observable/fromPromise';
 import 'rxjs/add/operator/timeout';
 import { ErrorMessageObserver } from '../../../src/observers/ErrorMessageObserver';
-import { ZipError, DotNetTestRunFailure, DotNetTestDebugStartFailure, EventWithMessage } from '../../../src/omnisharp/loggingEvents';
+import { ZipError, DotNetTestRunFailure, DotNetTestDebugStartFailure, EventWithMessage, IntegrityCheckFailure } from '../../../src/omnisharp/loggingEvents';
 
 chaiUse(require('chai-as-promised'));
 chaiUse(require('chai-string'));
@@ -40,4 +40,23 @@ suite("ErrorMessageObserver", () => {
             expect(errorMessage).to.be.contain(event.message);
         });
     });
+
+    suite(`${IntegrityCheckFailure.name}`, () => {
+        test("Package Description and url are logged when we are not retrying", () => {
+            let description = 'someDescription';
+            let url = 'someUrl';
+            let event = new IntegrityCheckFailure(description, url, false);
+            observer.post(event);
+            expect(errorMessage).to.contain(description);
+            expect(errorMessage).to.contain(url);
+        });
+    
+        test("Nothing is shown if we are retrying", () => {
+            let description = 'someDescription';
+            let url = 'someUrl';
+            let event = new IntegrityCheckFailure(description, url, true);
+            observer.post(event);
+            expect(errorMessage).to.be.undefined;
+        });
+    });
 });