Clean up and adding required fields. (#1284)

* Clean up and adding required fields.

Requiring pipeProgram and debuggerPath to PipeTransport.
Removing trace and trace response as they have been merged into engine
logging.

* Removing requirement on pipeProgram.

Author: WardenGnaw

package.json

@@ -696,22 +696,15 @@
                     "type": "boolean",
                     "description": "Optional flag to determine whether diagnostic engine logs should be logged to the output window.",
                     "default": false
-                  },
-                  "trace": {
-                    "type": "boolean",
-                    "description": "Optional flag to determine whether diagnostic adapter command tracing should be logged to the output window.",
-                    "default": false
-                  },
-                  "traceResponse": {
-                    "type": "boolean",
-                    "description": "Optional flag to determine whether diagnostic adapter command and response tracing should be logged to the output window.",
-                    "default": false
                   }
                 }
               },
               "pipeTransport": {
                 "description": "When present, this tells the debugger to connect to a remote computer using another executable as a pipe that will relay standard input/output between VS Code and the .NET Core debugger backend executable (clrdbg).",
                 "type": "object",
+                "required": [
+                  "debuggerPath"
+                ],
                 "default": {
                   "pipeCwd": "${workspaceRoot}",
                   "pipeProgram": "enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'",
@@ -946,22 +939,15 @@
                     "type": "boolean",
                     "description": "Optional flag to determine whether diagnostic engine logs should be logged to the output window.",
                     "default": false
-                  },
-                  "trace": {
-                    "type": "boolean",
-                    "description": "Optional flag to determine whether diagnostic adapter command tracing should be logged to the output window.",
-                    "default": false
-                  },
-                  "traceResponse": {
-                    "type": "boolean",
-                    "description": "Optional flag to determine whether diagnostic adapter command and response tracing should be logged to the output window.",
-                    "default": false
                   }
                 }
               },
               "pipeTransport": {
                 "description": "When present, this tells the debugger to connect to a remote computer using another executable as a pipe that will relay standard input/output between VS Code and the .NET Core debugger backend executable (clrdbg).",
                 "type": "object",
+                "required": [
+                  "debuggerPath"
+                ],
                 "default": {
                   "pipeCwd": "${workspaceRoot}",
                   "pipeProgram": "enter the fully qualified path for the pipe program name, for example '/usr/bin/ssh'",

src/tools/OptionsSchema.json

@@ -44,6 +44,7 @@
         },
         "PipeTransport": {
             "type": "object",
+            "required": ["debuggerPath"],
             "description": "When present, this tells the debugger to connect to a remote computer using another executable as a pipe that will relay standard input/output between VS Code and the .NET Core debugger backend executable (clrdbg).",
             "default": {
                 "pipeCwd": "${workspaceRoot}",
@@ -137,16 +138,6 @@
                     "type": "boolean",
                     "description": "Optional flag to determine whether diagnostic engine logs should be logged to the output window.",
                     "default": false
-                },
-                "trace": {
-                    "type": "boolean",
-                    "description": "Optional flag to determine whether diagnostic adapter command tracing should be logged to the output window.",
-                    "default": false
-                },
-                "traceResponse": {
-                    "type": "boolean",
-                    "description": "Optional flag to determine whether diagnostic adapter command and response tracing should be logged to the output window.",
-                    "default": false
                 }
             }
         },