Merged PR 473387: Detached Process

Launch the language server process as detached. That way, when a user exits VS Code the process can exit gracefully. This enables sending session telemetry on exit.

Author: Andrew Hall (METAL)

package.json

@@ -35,7 +35,7 @@
     }
   },
   "defaults": {
-    "roslyn": "4.7.0-2.23268.9",
+    "roslyn": "4.7.0-2.23272.2",
     "omniSharp": "1.39.6",
     "razor": "7.0.0-preview.23269.1"
   },
@@ -4809,4 +4809,4 @@
       }
     ]
   }
-}
+}

src/lsptoolshost/roslynLanguageServer.ts

@@ -386,13 +386,18 @@ export class RoslynLanguageServer {
         args.push("--telemetryLevel", this.telemetryReporter.telemetryLevel);
 
         let childProcess: cp.ChildProcessWithoutNullStreams;
+        let cpOptions: cp.SpawnOptionsWithoutStdio = {
+            detached: true,
+            windowsHide: true
+        };
+
         if (serverPath.endsWith('.dll')) {
             // If we were given a path to a dll, launch that via dotnet.
             const argsWithPath = [ serverPath ].concat(args);
-            childProcess = cp.spawn('dotnet', argsWithPath);
+            childProcess = cp.spawn('dotnet', argsWithPath, cpOptions);
         } else {
             // Otherwise assume we were given a path to an executable.
-            childProcess = cp.spawn(serverPath, args);
+            childProcess = cp.spawn(serverPath, args, cpOptions);
         }
 
         return childProcess;