Skip to content

Commit d06bb3e

Browse files
committed
Pass test parameter
1 parent 60dbba2 commit d06bb3e

File tree

2 files changed

+34
-29
lines changed

2 files changed

+34
-29
lines changed

azure-pipelines/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ stages:
116116
displayName: 'Install dependencies.'
117117
- pwsh: |
118118
# build number is generated by nerdbank git versioning and set to AzureDev
119-
gulp createTags --releaseVersion $(resources.pipeline.officialBuildCI.runName) --releaseCommit $(resources.pipeline.officialBuildCI.sourceCommit)
119+
gulp createTags --releaseVersion $(resources.pipeline.officialBuildCI.runName) --releaseCommit $(resources.pipeline.officialBuildCI.sourceCommit) --dryRun ${{ parameters.test }}
120120
env:
121121
GitHubPAT: $(BotAccount-dotnet-bot-content-rw-grained-pat)
122122
displayName: 'Create release tags'

tasks/createTagsTasks.ts

Lines changed: 33 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { Octokit } from '@octokit/rest';
1111
interface Options {
1212
releaseVersion: string;
1313
releaseCommit: string;
14+
dryRun: boolean;
1415
}
1516

1617
gulp.task('createTags', async (): Promise<void> => {
@@ -24,35 +25,39 @@ gulp.task('createTags', async (): Promise<void> => {
2425
return;
2526
}
2627

27-
const tagCreatedInRoslyn = await tagRepoAsync(
28-
'dotnet',
29-
'roslyn',
30-
roslynCommit,
31-
`VSCode-CSharp-${options.releaseVersion}`,
32-
`${options.releaseVersion} VSCode C# extension release`
33-
);
34-
35-
if (!tagCreatedInRoslyn) {
36-
logError('Failed to tag roslyn');
37-
return;
38-
}
39-
40-
console.log('tag created in roslyn');
41-
42-
const tagCreatedInVsCodeCsharp = await tagRepoAsync(
43-
'dotnet',
44-
'vscode-csharp',
45-
options.releaseCommit,
46-
options.releaseVersion,
47-
options.releaseVersion
48-
);
49-
50-
if (!tagCreatedInVsCodeCsharp) {
51-
logError('Failed to tag vscode-csharp');
52-
return;
28+
if (options.dryRun) {
29+
console.log('Tagging is skipped in dry run mode.');
30+
} else {
31+
const tagCreatedInRoslyn = await tagRepoAsync(
32+
'dotnet',
33+
'roslyn',
34+
roslynCommit,
35+
`VSCode-CSharp-${options.releaseVersion}`,
36+
`${options.releaseVersion} VSCode C# extension release`
37+
);
38+
39+
if (!tagCreatedInRoslyn) {
40+
logError('Failed to tag roslyn');
41+
return;
42+
}
43+
44+
console.log('tag created in roslyn');
45+
46+
const tagCreatedInVsCodeCsharp = await tagRepoAsync(
47+
'dotnet',
48+
'vscode-csharp',
49+
options.releaseCommit,
50+
options.releaseVersion,
51+
options.releaseVersion
52+
);
53+
54+
if (!tagCreatedInVsCodeCsharp) {
55+
logError('Failed to tag vscode-csharp');
56+
return;
57+
}
58+
59+
console.log('tag created in vscode-csharp');
5360
}
54-
55-
console.log('tag created in vscode-csharp');
5661
});
5762

5863
async function findRoslynCommitAsync(): Promise<string | null> {

0 commit comments

Comments
 (0)