Warn in the statusbar when the active file is not part of the open workspace.

Author: JoeRobich

src/lsptoolshost/languageStatusBar.ts

@@ -10,12 +10,20 @@ import { languageServerOptions } from '../shared/options';
 import { ServerState } from './serverStateChange';
 import { getCSharpDevKit } from '../utils/getCSharpDevKit';
 import { RazorLanguage } from '../razor/src/razorLanguage';
+import { VSWorkspaceKind } from './roslynProtocol';
+
+let currentServerState: ServerState = ServerState.Stopped;
 
 export function registerLanguageStatusItems(
     context: vscode.ExtensionContext,
     languageServer: RoslynLanguageServer,
     languageServerEvents: RoslynLanguageServerEvents
 ) {
+    // Track the current server state.
+    languageServerEvents.onServerStateChange((e) => {
+        currentServerState = e.state;
+    });
+
     // DevKit will provide an equivalent workspace status item.
     if (!getCSharpDevKit()) {
         WorkspaceStatus.createStatusItem(context, languageServerEvents);
@@ -44,14 +52,16 @@ class WorkspaceStatus {
 
         const item = vscode.languages.createLanguageStatusItem('csharp.workspaceStatus', documentSelector);
         item.name = vscode.l10n.t('C# Workspace Status');
+        item.severity = vscode.LanguageStatusSeverity.Error;
+        item.command = openSolutionCommand;
         context.subscriptions.push(item);
 
         languageServerEvents.onServerStateChange((e) => {
             item.text = e.workspaceLabel;
             item.busy = e.state === ServerState.ProjectInitializationStarted;
             item.severity =
                 e.state === ServerState.Stopped
-                    ? vscode.LanguageStatusSeverity.Warning
+                    ? vscode.LanguageStatusSeverity.Error
                     : vscode.LanguageStatusSeverity.Information;
             item.command = e.state === ServerState.Stopped ? restartServerCommand : openSolutionCommand;
         });
@@ -73,6 +83,17 @@ class ProjectContextStatus {
 
         projectContextService.onActiveFileContextChanged((e) => {
             item.text = e.context._vs_label;
+
+            // Show a warning when the active file is part of the Miscellaneous File workspace and
+            // project initialization is complete.
+            if (currentServerState === ServerState.ProjectInitializationComplete) {
+                item.severity =
+                    e.context._vs_workspace_kind === VSWorkspaceKind.MiscellaneousFiles
+                        ? vscode.LanguageStatusSeverity.Warning
+                        : vscode.LanguageStatusSeverity.Information;
+            } else {
+                item.severity = vscode.LanguageStatusSeverity.Information;
+            }
         });
 
         // Trigger a refresh, but don't block creation on the refresh completing.

src/lsptoolshost/roslynProtocol.ts

@@ -13,10 +13,17 @@ export interface VSProjectContextList {
     _vs_defaultIndex: number;
 }
 
+export enum VSWorkspaceKind {
+    Unknown = 0,
+    Host = 1,
+    MiscellaneousFiles = 2,
+}
+
 export interface VSProjectContext {
     _vs_label: string;
     _vs_id: string;
     _vs_kind: string;
+    _vs_workspace_kind: VSWorkspaceKind;
 }
 
 export interface VSTextDocumentIdentifier extends lsp.TextDocumentIdentifier {

src/lsptoolshost/services/projectContextService.ts

@@ -5,7 +5,12 @@
 
 import * as vscode from 'vscode';
 import { RoslynLanguageServer } from '../roslynLanguageServer';
-import { VSGetProjectContextsRequest, VSProjectContext, VSProjectContextList } from '../roslynProtocol';
+import {
+    VSGetProjectContextsRequest,
+    VSProjectContext,
+    VSProjectContextList,
+    VSWorkspaceKind,
+} from '../roslynProtocol';
 import { TextDocumentIdentifier } from 'vscode-languageserver-protocol';
 import { UriConverter } from '../uriConverter';
 import { LanguageServerEvents } from '../languageServerEvents';
@@ -26,6 +31,7 @@ export class ProjectContextService {
         _vs_id: '',
         _vs_kind: '',
         _vs_label: '',
+        _vs_workspace_kind: VSWorkspaceKind.Unknown,
     };
 
     constructor(private _languageServer: RoslynLanguageServer, _languageServerEvents: LanguageServerEvents) {