project system errors

Author: beccamc

src/lsptoolshost/buildDiagnosticsService.ts

@@ -94,9 +94,14 @@ export class BuildDiagnosticsService {
         const buildOnlyDiagnostics: vscode.Diagnostic[] = [];
         diagnosticList.forEach((d) => {
             if (d.code) {
-                // If it is a "build-only"diagnostics (e.g. it can only be found by building)
-                // the diagnostic will always be included
-                if (buildOnlyIds.find((b_id) => b_id === d.code)) {
+                // If it is a project system diagnostic (e.g. "Target framework out of support")
+                // then always show it. It cannot be reported by live.
+                if (this.isProjectSystemDiagnostic(d)) {
+                    buildOnlyDiagnostics.push(d);
+                }
+                // If it is a "build-only"diagnostics (i.e. it can only be found by building)
+                // then always show it. It cannot be reported by live.
+                else if (buildOnlyIds.find((b_id) => b_id === d.code)) {
                     buildOnlyDiagnostics.push(d);
                 } else {
                     const isAnalyzerDiagnostic = BuildDiagnosticsService.isAnalyzerDiagnostic(d);
@@ -134,4 +139,8 @@ export class BuildDiagnosticsService {
     private static isAnalyzerDiagnostic(d: vscode.Diagnostic): boolean {
         return d.code ? !d.code.toString().startsWith('CS') : false;
     }
+
+    private static isProjectSystemDiagnostic(d: vscode.Diagnostic): boolean {
+        return d.code ? d.code.toString().startsWith('NETSDK') : false;
+    }
 }

test/integrationTests/buildDiagnostics.integration.test.ts

@@ -119,6 +119,24 @@ describe(`Build and live diagnostics dedupe ${testAssetWorkspace.description}`,
         expect(displayedBuildResults.length).toEqual(2);
         expect(displayedBuildResults).toContain(diagnostics[0]);
     });
+
+    test('Project system diagnostics', async () => {
+        await setBackgroundAnalysisSetting(
+            /*analyzer*/ AnalysisSetting.OpenFiles,
+            /*compiler*/ AnalysisSetting.OpenFiles
+        );
+
+        const buildOnlyIds = ['CS1001'];
+        const diagnostics = [getTestDiagnostic('NETSDK3001')];
+
+        const displayedBuildResults = BuildDiagnosticsService.filerDiagnosticsFromBuild(
+            diagnostics,
+            buildOnlyIds,
+            true
+        );
+
+        expect(displayedBuildResults.length).toEqual(1);
+    });
 });
 
 function getTestDiagnostic(code: string): vscode.Diagnostic {