Rename id and provide try catch

Author: akshita31

src/coreclr-debug/activate.ts

@@ -133,7 +133,6 @@ export async function getAdapterExecutionCommand(platformInfo: PlatformInformati
             installLock = await common.installFileExists(debuggerPackage.installPath, common.InstallFileType.Lock);
         }
 
-        //todo: check if the debugger install.lock is present
         if (!installLock) {
             eventStream.post(new DebuggerNotInstalledFailure());
             throw new Error('The C# extension is still downloading packages. Please see progress in the output window below.');

src/packageManager/AbsolutePathPackage.ts

@@ -8,7 +8,7 @@ import { IPackage } from "./IPackage";
 import { AbsolutePath } from "./AbsolutePath";
 
 export class AbsolutePathPackage implements IPackage{
-    constructor(public Id: string,
+    constructor(public id: string,
         public description: string,
         public url: string,
         public platforms: string[],
@@ -22,7 +22,7 @@ export class AbsolutePathPackage implements IPackage{
 
     public static getAbsolutePathPackage(pkg: Package, extensionPath: string) {
         return new AbsolutePathPackage(
-            pkg.Id,
+            pkg.id,
             pkg.description,
             pkg.url,
             pkg.platforms,

src/packageManager/IPackage.ts

@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 export interface IPackage {
-    Id: string;
+    id: string;
     description: string;
     url: string;
     fallbackUrl?: string;

src/packageManager/PackageManager.ts

@@ -13,7 +13,7 @@ import { EventStream } from '../EventStream';
 import { NetworkSettingsProvider } from "../NetworkSettings";
 import { filterPackages } from "./PackageFilterer";
 import { AbsolutePathPackage } from "./AbsolutePathPackage";
-import { touchInstallFile, InstallFileType, deleteInstallFile } from "../common";
+import { touchInstallFile, InstallFileType, deleteInstallFile, installFileExists } from "../common";
 import { InstallationFailure } from "../omnisharp/loggingEvents";
 import { mkdirpSync } from "fs-extra";
 
@@ -46,7 +46,12 @@ export async function DownloadAndInstallPackages(packages: Package[], provider:
                 }
             }
             finally {
-                await deleteInstallFile(pkg.installPath, InstallFileType.Begin);
+                try {
+                    if (installFileExists(pkg.installPath, InstallFileType.Begin)) {
+                        await deleteInstallFile(pkg.installPath, InstallFileType.Begin);
+                    }
+                }
+                catch (error) { }
             }
         }
     }

src/tools/GetRuntimeDependencyWithId.ts

@@ -12,5 +12,5 @@ export function getRuntimeDependencyPackageWithId(packageId: string, packageJSON
     let runtimeDependencies = GetRunTimeDependenciesPackages(packageJSON);
     let absolutePathPackages = runtimeDependencies.map(pkg => AbsolutePathPackage.getAbsolutePathPackage(pkg, extensionPath));
     let platformSpecificPackage = filterPlatformPackages(absolutePathPackages, platformInfo);
-    return platformSpecificPackage.find(pkg => pkg.Id == packageId);
+    return platformSpecificPackage.find(pkg => pkg.id == packageId);
 }