Merge pull request #6139 from dibarbet/dev/dibarbet/release_approvals

Use deployment stage to require a manual approval to run the pipeline

Author: dibarbet

azure-pipelines/release.yml

@@ -17,64 +17,70 @@ variables:
 - group: vscode-csharp release secrets
 
 jobs:
-- job: PublishToMarketplace
+- deployment: PublishToMarketplace
+  displayName: PublishToMarketplace
+  environment: vscode-csharp-release-approvals
   pool:
     vmImage: ubuntu-latest
-  steps:
-  - task: DownloadPipelineArtifact@2
-    displayName: '📦 Download artifacts from build pipeline.'
-    inputs:
-      buildType: 'specific'
-      project: 'internal'
-      definition: 1264
-      buildVersionToDownload: 'specific'
-      buildId: '$(resources.pipeline.officialBuildCI.runID)'
-      branchName: '$(resources.pipeline.officialBuildCI.sourceBranch)'
-  - pwsh: |
-      npm install --global vsce
-    displayName: 'Install vsce'
-  - pwsh: |
-      # Our build pipeline would generated build based on attempt number. Publishing the latest attempt.
-      $allArtifacts = Get-ChildItem -Path "VSIXs - Attempt*" | Sort-Object -Descending
-      if ($allArtifacts.Length -eq 0) {
-        throw "No Artifacts is downloaded."
-      }
+  strategy:
+    runOnce:
+      deploy:
+        steps:
+        - download: 'none'
+        - task: DownloadPipelineArtifact@2
+          displayName: '📦 Download artifacts from build pipeline.'
+          inputs:
+            buildType: 'specific'
+            project: 'internal'
+            definition: 1264
+            buildVersionToDownload: 'specific'
+            buildId: '$(resources.pipeline.officialBuildCI.runID)'
+            branchName: '$(resources.pipeline.officialBuildCI.sourceBranch)'
+        - pwsh: |
+            npm install --global vsce
+          displayName: 'Install vsce'
+        - pwsh: |
+            # Our build pipeline would generated build based on attempt number. Publishing the latest attempt.
+            $allArtifacts = Get-ChildItem -Path "VSIXs - Attempt*" | Sort-Object -Descending
+            if ($allArtifacts.Length -eq 0) {
+              throw "No Artifacts is downloaded."
+            }
 
-      $publishArtifacts = $allArtifacts[0]
-      Write-Host "All artifacts: $($allArtifacts). Publishing $($publishArtifacts)."
+            $publishArtifacts = $allArtifacts[0]
+            Write-Host "All artifacts: $($allArtifacts). Publishing $($publishArtifacts)."
 
-      $additionalPublishArgs = , "publish"
-      # Artifacts are published to either pre-release or release based on the build branch, https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions
-      If ("$(resources.pipeline.officialBuildCI.sourceBranch)" -eq "refs/heads/main") {
-        $additionalPublishArgs += "--pre-release"
-        Write-Host "Publish to pre-release channel."
-      } ElseIf ("$(resources.pipeline.officialBuildCI.sourceBranch)" -eq "refs/heads/release") {
-        Write-Host "Publish to release channel."
-      } Else {
-        throw "Unexpected branch name: $(resources.pipeline.officialBuildCI.sourceBranch)."
-      }
-      $additionalPublishArgs += '--packagePath'
+            $additionalPublishArgs = , "publish"
+            # Artifacts are published to either pre-release or release based on the build branch, https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions
+            If ("$(resources.pipeline.officialBuildCI.sourceBranch)" -eq "refs/heads/main") {
+              $additionalPublishArgs += "--pre-release"
+              Write-Host "Publish to pre-release channel."
+            } ElseIf ("$(resources.pipeline.officialBuildCI.sourceBranch)" -eq "refs/heads/release") {
+              Write-Host "Publish to release channel."
+            } Else {
+              throw "Unexpected branch name: $(resources.pipeline.officialBuildCI.sourceBranch)."
+            }
+            $additionalPublishArgs += '--packagePath'
 
-      $platforms = "arm64", "x64", "ia32"
-      $allVsixs = Get-ChildItem $publishArtifacts *.vsix
-      foreach ($vsix in $allVsixs) {
-        foreach ($plat in $platforms) {
-          if ($vsix.Name.Contains($plat)) {
-              $additionalPublishArgs += $vsix
-          }
-        }
-      }
+            $platforms = "arm64", "x64", "ia32"
+            $allVsixs = Get-ChildItem $publishArtifacts *.vsix
+            foreach ($vsix in $allVsixs) {
+              foreach ($plat in $platforms) {
+                if ($vsix.Name.Contains($plat)) {
+                    $additionalPublishArgs += $vsix
+                }
+              }
+            }
 
-      Write-Host "Command run is: vsce $($additionalPublishArgs)."
-      If ("${{ parameters.test }}" -eq "true") {
-        Write-Host "In test mode, command is printed instead of run."
-        Write-Host "🔒 Verify PAT."
-        vsce verify-pat ms-dotnettools
-      }
-      Else {
-        vsce @additionalPublishArgs
-      }
-    displayName: 🚀 Publish to Marketplace
-    workingDirectory: $(Pipeline.Workspace)
-    env:
-      VSCE_PAT: $(VSCodeMarketplacePAT)
+            Write-Host "Command run is: vsce $($additionalPublishArgs)."
+            If ("${{ parameters.test }}" -eq "true") {
+              Write-Host "In test mode, command is printed instead of run."
+              Write-Host "🔒 Verify PAT."
+              vsce verify-pat ms-dotnettools
+            }
+            Else {
+              vsce @additionalPublishArgs
+            }
+          displayName: 🚀 Publish to Marketplace
+          workingDirectory: $(Pipeline.Workspace)
+          env:
+            VSCE_PAT: $(VSCodeMarketplacePAT)