Merge pull request #6231 from dotnet/dev/arkalyan/symlink

Replace symlink resolution with realpath

Author: Cosifne

CHANGELOG.md

@@ -9,6 +9,9 @@
 - Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876)
 
 ## Latest
+* Fix UriFormatException during dotnet SDK resolution when symlinks are involved (PR: [#6230](https://github.com/dotnet/vscode-csharp/pull/6230))
+
+## 2.0.413
 * Update Roslyn version (PR: [#6192](https://github.com/dotnet/vscode-csharp/pull/6192))
   * Add support for compilation end diagnostics (PR: [#69541](https://github.com/dotnet/roslyn/pull/69541))
   * Include CodeLens on more types and members (PR: [#69608](https://github.com/dotnet/roslyn/pull/69608))

src/lsptoolshost/dotnetRuntimeExtensionResolver.ts

@@ -15,7 +15,7 @@ import { CSharpExtensionId } from '../constants/csharpExtensionId';
 import { promisify } from 'util';
 import { exec } from 'child_process';
 import { getDotnetInfo } from '../shared/utils/getDotnetInfo';
-import { readFile, readlink } from 'fs/promises';
+import { readFile, realpath } from 'fs/promises';
 
 export const DotNetRuntimeVersion = '7.0';
 
@@ -183,13 +183,7 @@ export class DotnetRuntimeExtensionResolver implements IHostExecutableResolver {
 
             // If dotnet is just a symlink, resolve it to the actual executable so
             // callers will be able to get the actual directory containing the exe.
-            try {
-                const targetPath = await readlink(path);
-                return targetPath;
-            } catch {
-                // Not a symlink.
-                return path;
-            }
+            return await realpath(path);
         } catch (e) {
             this.channel.appendLine(
                 'Failed to find dotnet info from path, falling back to acquire runtime via ms-dotnettools.vscode-dotnet-runtime'