return properly

Author: akshita31

src/features/codeLensProvider.ts

@@ -123,7 +123,7 @@ export default class OmniSharpCodeLensProvider extends AbstractProvider implemen
         try {
             let result = await serverUtils.findUsages(this._server, request, token);
             if (!result || !result.QuickFixes) {
-                return;
+                return undefined;
             }
 
             const quickFixes = result.QuickFixes;
@@ -138,7 +138,7 @@ export default class OmniSharpCodeLensProvider extends AbstractProvider implemen
             return codeLens;
         }
         catch (error) {
-            return;
+            return undefined;
         }
     }
 
@@ -159,7 +159,7 @@ export default class OmniSharpCodeLensProvider extends AbstractProvider implemen
             projectInfo = await serverUtils.requestProjectInformation(this._server, { FileName: codeLens.fileName });
         }
         catch (error) {
-            return;
+            return undefined;
         }
 
         // We do not support running all tests on legacy projects.

src/features/dotnetTest.ts

@@ -122,11 +122,11 @@ export default class TestManager extends AbstractProvider {
             return response.Results;
         }
         catch (error) {
-            return;
+            return undefined;
         }
     }
 
-    private async _recordRunAndGetFrameworkVersion(fileName: string, testFrameworkName: string) {
+    private async _recordRunAndGetFrameworkVersion(fileName: string, testFrameworkName: string): Promise<string>{
 
         await this._saveDirtyFiles();
         this._recordRunRequest(testFrameworkName);
@@ -135,7 +135,7 @@ export default class TestManager extends AbstractProvider {
             projectInfo = await serverUtils.requestProjectInformation(this._server, { FileName: fileName });
         }
         catch (error) {
-            return;
+            return undefined;
         }
 
         let targetFrameworkVersion: string;
@@ -318,7 +318,7 @@ export default class TestManager extends AbstractProvider {
             projectInfo = await serverUtils.requestProjectInformation(this._server, { FileName: fileName });
         }
         catch (error) {
-            return;
+            return undefined;
         }
 
         let debugType: string;

src/features/renameProvider.ts

@@ -21,7 +21,7 @@ export default class OmnisharpRenameProvider extends AbstractSupport implements
             let response = await serverUtils.rename(this._server, req, token);
 
             if (!response) {
-                return;
+                return undefined;
             }
 
             const edit = new WorkspaceEdit();
@@ -37,7 +37,7 @@ export default class OmnisharpRenameProvider extends AbstractSupport implements
             return edit;
         }
         catch (error) {
-            return;
+            return undefined;
         }
     }
 }

src/features/signatureHelpProvider.ts

@@ -44,7 +44,7 @@ export default class OmniSharpSignatureHelpProvider extends AbstractSupport impl
             return ret;
         }
         catch (error) {
-            return;
+            return undefined;
         }
     }
 

src/features/structureProvider.ts

@@ -23,9 +23,9 @@ export class StructureProvider extends AbstractSupport implements FoldingRangePr
 
             return ranges;
         }
-        catch (error) { }
-
-        return [];
+        catch (error) {
+            return [];
+        }
     }
 
     GetType(type: string): FoldingRangeKind {

src/observers/DotnetTestLoggerObserver.ts

@@ -70,31 +70,33 @@ export default class DotNetTestLoggerObserver extends BaseLoggerObserver {
     }
 
     private handleReportDotnetTestResults(event: ReportDotNetTestResults) {
-        this.logger.appendLine("----- Test Execution Summary -----");
-        this.logger.appendLine('');
-        
-        // Omnisharp returns null results if there are build failures
-        const results = event.results || [];
-        const totalTests = results.length;
-
-        let totalPassed = 0, totalFailed = 0, totalSkipped = 0;
-        for (let result of results) {
-            this.logTestResult(result);
-            switch (result.Outcome) {
-                case protocol.V2.TestOutcomes.Failed:
-                    totalFailed += 1;
-                    break;
-                case protocol.V2.TestOutcomes.Passed:
-                    totalPassed += 1;
-                    break;
-                case protocol.V2.TestOutcomes.Skipped:
-                    totalSkipped += 1;
-                    break;
+        if (event.results) {
+            this.logger.appendLine("----- Test Execution Summary -----");
+            this.logger.appendLine('');
+
+            // Omnisharp returns null results if there are build failures
+            const results = event.results;
+            const totalTests = results.length;
+
+            let totalPassed = 0, totalFailed = 0, totalSkipped = 0;
+            for (let result of results) {
+                this.logTestResult(result);
+                switch (result.Outcome) {
+                    case protocol.V2.TestOutcomes.Failed:
+                        totalFailed += 1;
+                        break;
+                    case protocol.V2.TestOutcomes.Passed:
+                        totalPassed += 1;
+                        break;
+                    case protocol.V2.TestOutcomes.Skipped:
+                        totalSkipped += 1;
+                        break;
+                }
             }
-        }
 
-        this.logger.appendLine(`Total tests: ${totalTests}. Passed: ${totalPassed}. Failed: ${totalFailed}. Skipped: ${totalSkipped}`);
-        this.logger.appendLine('');
+            this.logger.appendLine(`Total tests: ${totalTests}. Passed: ${totalPassed}. Failed: ${totalFailed}. Skipped: ${totalSkipped}`);
+            this.logger.appendLine('');
+        }
     }
 
     private logTestResult(result: protocol.V2.DotNetTestResult) {